Skip to content

Conversation

AmineKhaldi
Copy link
Contributor

@AmineKhaldi AmineKhaldi commented Sep 2, 2025

Purpose:

Addresses https://github.com/Chia-Network/chia-blockchain/actions/runs/17383374050/job/49377026478#step:13:47

Current Behavior:

New Behavior:

Testing Notes:

@AmineKhaldi AmineKhaldi self-assigned this Sep 2, 2025
@AmineKhaldi AmineKhaldi added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Sep 2, 2025
@AmineKhaldi AmineKhaldi changed the title Explore building chiavdf for MacOS without installing CMake Build chiavdf for MacOS without installing CMake Sep 2, 2025
@AmineKhaldi AmineKhaldi changed the title Build chiavdf for MacOS without installing CMake CHIA-3718 Build chiavdf for MacOS without installing CMake Sep 2, 2025
@AmineKhaldi AmineKhaldi marked this pull request as ready for review September 2, 2025 10:39
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner September 2, 2025 10:39
@arvidn
Copy link
Contributor

arvidn commented Sep 2, 2025

I assume install-timelord.sh is meant to work on end-user's machines as well. Where cmake may not already be installed

@AmineKhaldi AmineKhaldi force-pushed the explore_building_chiavdf branch from 87d6806 to 80bdb57 Compare September 2, 2025 11:05
@AmineKhaldi AmineKhaldi changed the title CHIA-3718 Build chiavdf for MacOS without installing CMake CHIA-3718 Handle building chiavdf for MacOS when CMake is already installed Sep 2, 2025
@AmineKhaldi
Copy link
Contributor Author

I assume install-timelord.sh is meant to work on end-user's machines as well. Where cmake may not already be installed

We now check if CMake exists, and if not, we install it.

@arvidn
Copy link
Contributor

arvidn commented Sep 2, 2025

this looks good to me. I'd like someone else to review it as well though

Copy link

Pull Request Test Coverage Report for Build 17401543637

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 56 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.04%) to 91.269%

Files with Coverage Reduction New Missed Lines %
chia/wallet/wallet_node.py 2 87.56%
chia/full_node/weight_proof.py 4 90.6%
chia/full_node/full_node_api.py 6 86.07%
chia/full_node/full_node.py 9 87.56%
chia/server/node_discovery.py 10 80.5%
chia/_tests/core/util/test_lockfile.py 25 77.31%
Totals Coverage Status
Change from base Build 17309077769: -0.04%
Covered Lines: 102699
Relevant Lines: 112391

💛 - Coveralls

@cmmarslender cmmarslender merged commit 061d588 into Chia-Network:main Sep 2, 2025
528 of 531 checks passed
altendky pushed a commit that referenced this pull request Sep 5, 2025
…talled (#20018)

Handle building chiavdf for MacOS when CMake is already installed.

(cherry picked from commit 061d588)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants