Skip to content

remove unnecessary NPCResult in mempool_manager #20022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 5, 2025
Merged

remove unnecessary NPCResult in mempool_manager #20022

merged 3 commits into from
Sep 5, 2025

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Sep 3, 2025

Purpose:

Minor simplification

@arvidn arvidn requested a review from a team as a code owner September 3, 2025 07:24
@arvidn arvidn requested a review from AmineKhaldi September 3, 2025 07:24
@arvidn arvidn added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Sep 3, 2025
AmineKhaldi
AmineKhaldi reviewed Sep 3, 2025
View reviewed changes
AmineKhaldi
AmineKhaldi previously approved these changes Sep 3, 2025
View reviewed changes
@arvidn arvidn requested a review from AmineKhaldi September 3, 2025 20:21
@arvidn arvidn requested a review from wjblanke September 4, 2025 09:58
wjblanke
wjblanke approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Sep 5, 2025
@pmaslana pmaslana merged commit f2d9281 into main Sep 5, 2025
244 checks passed
@pmaslana pmaslana deleted the npcresult-in-mempool branch September 5, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmineKhaldi AmineKhaldi AmineKhaldi approved these changes

@wjblanke wjblanke wjblanke approved these changes

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arvidn @AmineKhaldi @wjblanke @pmaslana