[CHIA-3729] Fix clvm streamable type analysis #20031
Merged
+33
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
force-pushed
the
quex.fix_clvm_streamable_type_analysis
branch
from
1abecf8 to
2397450
Compare
Quexington
added
the
Fixed
Quexington
force-pushed
the
quex.fix_clvm_streamable_type_analysis
branch
from
2397450 to
49a6879
Compare
Quexington
changed the title
Quexington
force-pushed
the
quex.fix_clvm_streamable_type_analysis
branch
2 times, most recently
from
2393887 to
ea90ae5
Compare
Quexington
force-pushed
the
quex.fix_clvm_streamable_type_analysis
branch
from
ea90ae5 to
46ea7fd
Compare
…with a little mypy workaround)
Quexington
force-pushed
the
quex.fix_clvm_streamable_type_analysis
branch
from
46ea7fd to
9cce49d
Compare
altendky
approved these changes
Sep 9, 2025
|
emlowe
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative for #20020
3.13 raised an issue with using
issubclasson generic type hints. This PR does fix that issue, but the investigation revealed a problem with the recursive functionality of theclvm_streamabledeserialization from JSON.After a few iterations, I realized the problem was primarily that by hacking some mutual recursive-ness into
function_to_convert_one_itemI hadn't fully supported crossing the barrier more than once. This has been fine but was bugged for things like dicts and sufficiently recursive stuff. By re-hacking the streamable portion a little bit, I was able to simplify the overall code and have it support more stuff more gracefully.