Skip to content

Conversation

almogdepaz
Copy link
Contributor

Purpose:

fix edge case looking up sps in genesis, we had a bug which mage us miss sps in the first slot
for the first slot we use None when looking up instead of looking for the slot to get the challenge we should use Genesis challenge, slot None only happens for the first slot in the chain

Current Behavior:

New Behavior:

Testing Notes:

@almogdepaz almogdepaz marked this pull request as ready for review September 11, 2025 13:23
@almogdepaz almogdepaz requested a review from a team as a code owner September 11, 2025 13:23
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@almogdepaz almogdepaz added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Sep 15, 2025
Copy link

Pull Request Test Coverage Report for Build 17646525702

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • 160 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.1%) to 91.119%

Files with Coverage Reduction New Missed Lines %
chia/daemon/client.py 1 74.16%
chia/daemon/keychain_proxy.py 1 70.57%
chia/daemon/server.py 1 83.54%
chia/farmer/farmer.py 1 73.32%
chia/full_node/full_node_store.py 1 92.93%
chia/introducer/introducer.py 1 81.9%
chia/timelord/timelord_api.py 1 93.02%
chia/timelord/timelord_launcher.py 2 89.29%
chia/_tests/simulation/test_simulation.py 3 96.47%
chia/introducer/introducer_api.py 5 81.48%
Totals Coverage Status
Change from base Build 17624749078: -0.1%
Covered Lines: 102724
Relevant Lines: 112573

💛 - Coveralls

@pmaslana pmaslana merged commit dbd6700 into main Sep 16, 2025
526 of 529 checks passed
@pmaslana pmaslana deleted the fix-genesis-sp-lookup branch September 16, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants