Skip to content

Conversation

cmmarslender
Copy link
Member

@cmmarslender cmmarslender commented Sep 12, 2025

  • Update all installer builds to use the version of node specified in chia-blockchain-gui .nvmrc
  • Update the workflows that didn't previously use the setup-node action to use it, to make future updates easier (this action now works with all the currently supported platforms we build on)

@cmmarslender cmmarslender added CI CI changes Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes Changed Required label for PR that categorizes merge commit message as "Changed" for changelog and removed Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Sep 12, 2025
Copy link

coveralls-official bot commented Sep 15, 2025

Pull Request Test Coverage Report for Build 17745250943

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 215 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.007%) to 91.241%

Files with Coverage Reduction New Missed Lines %
chia/daemon/keychain_proxy.py 1 70.57%
chia/farmer/farmer.py 1 73.32%
chia/_tests/plotting/test_plot_manager.py 1 98.19%
chia/util/config.py 1 82.25%
chia/daemon/client.py 2 74.16%
chia/wallet/wallet_node.py 2 87.13%
chia/_tests/wallet/rpc/test_wallet_rpc.py 6 99.02%
chia/server/node_discovery.py 7 81.22%
chia/cmds/coin_funcs.py 8 88.24%
chia/wallet/wallet_request_types.py 8 99.32%
Totals Coverage Status
Change from base Build 17650144354: 0.007%
Covered Lines: 102801
Relevant Lines: 112532

💛 - Coveralls

@cmmarslender cmmarslender changed the title Test using setup-node + node22 on all installer builds Update to node 22 on all installer builds. Use setup-node action where it was not used previously Sep 15, 2025
@cmmarslender cmmarslender marked this pull request as ready for review September 15, 2025 19:49
@cmmarslender cmmarslender requested a review from a team as a code owner September 15, 2025 19:49
@cmmarslender cmmarslender changed the title Update to node 22 on all installer builds. Use setup-node action where it was not used previously Use setup-node action and .nvmrc specified version for all installers Sep 15, 2025
@cmmarslender cmmarslender requested a review from emlowe September 15, 2025 20:29
@cmmarslender cmmarslender merged commit 83e164d into main Sep 16, 2025
418 of 421 checks passed
@cmmarslender cmmarslender deleted the node22 branch September 16, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog CI CI changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants