Skip to content

Conversation

AmineKhaldi
Copy link
Contributor

Purpose:

Instead of tracking eligible_for_fast_forward introduce a supports_fast_forward property that is true when a spend has fast forward unspent lineage information.

This simplifies determining when a spend supports fast forward without data duplication, and it renders the state where eligible_for_fast_forward is true without lineage information, impossible.

Current Behavior:

We track fast forward spends information through both eligible_for_fast_forward and latest_singleton_lineage.

New Behavior:

We determine supports_fast_forward based on latest_singleton_lineage.

Testing Notes:

@AmineKhaldi AmineKhaldi self-assigned this Sep 16, 2025
@AmineKhaldi AmineKhaldi added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Sep 16, 2025
Copy link

Pull Request Test Coverage Report for Build 17768307977

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 24 of 24 (100.0%) changed or added relevant lines in 5 files are covered.
  • 6 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.003%) to 91.245%

Files with Coverage Reduction New Missed Lines %
chia/daemon/client.py 1 74.16%
chia/daemon/keychain_proxy.py 1 70.57%
chia/farmer/farmer.py 1 73.32%
chia/full_node/full_node_api.py 1 85.52%
chia/server/node_discovery.py 2 82.11%
Totals Coverage Status
Change from base Build 17740066828: -0.003%
Covered Lines: 102795
Relevant Lines: 112519

💛 - Coveralls

Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@arvidn arvidn closed this Sep 19, 2025
@arvidn arvidn reopened this Sep 19, 2025
@arvidn
Copy link
Contributor

arvidn commented Sep 19, 2025

I'm not sure what's missing for this to be ready for review

@AmineKhaldi
Copy link
Contributor Author

I'm not sure what's missing for this to be ready for review

It was failing CI so it didn't get undrafted.

@AmineKhaldi AmineKhaldi marked this pull request as ready for review September 19, 2025 10:07
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner September 19, 2025 10:07
@pmaslana pmaslana merged commit cfeeae1 into Chia-Network:main Sep 19, 2025
908 of 924 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants