-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Remove scripting that attempts to find and install node #20082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 17840058243Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for testing that @ChiaMineJP - I missed that case |
@ChiaMineJP I believe I have fixed up the script to handle this case now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it looks good to me 👍
Similar to what was done with python some time ago - eliminate the code in the install-gui script that tries to find and install node. This simplifies the script considerably, and it places the burden on the user to make sure they have the proper version for their OS
Since our CI always make sure the runners have the proper version of node installed this change has no affect on CI. Very few users try to install the run the GUI from source so this has limited impact to actual users - and those users can easily get NodeJS from official channels
The trigger for this change was problems the script was having using brew to install node on macOS 13. Rather than change it to use alternative means, this change is simpler and removes a bunch of scripting and follows along with the precedent we made earlier for python