Skip to content

Conversation

altendky
Copy link
Contributor

Source hash: eadce79
Remaining commits: 0

fchirica and others added 30 commits November 13, 2024 03:05
<!-- Merging Requirements:
- Please give your PR a title that is release-note friendly
- In order to be merged, you must add the most appropriate category
Label (Added, Changed, Fixed) to your PR
-->
<!-- Explain why this is an improvement (Does this add missing
functionality, improve performance, or reduce complexity?) -->

### Purpose:

<!-- Does this PR introduce a breaking change? -->

### Current Behavior:

### New Behavior:

<!-- As we aim for complete code coverage, please include details
regarding unit, and regression tests -->

### Testing Notes:

<!-- Attach any visual examples, or supporting evidence (attach any
.gif/video/console output below) -->
…long_lived_datalayer_merkle_blob_from_main_748c8cec8e24c0feabc10e8db22284dc3712180f
<!-- Merging Requirements:
- Please give your PR a title that is release-note friendly
- In order to be merged, you must add the most appropriate category
Label (Added, Changed, Fixed) to your PR
-->
<!-- Explain why this is an improvement (Does this add missing
functionality, improve performance, or reduce complexity?) -->

### Purpose:

<!-- Does this PR introduce a breaking change? -->

### Current Behavior:

### New Behavior:

<!-- As we aim for complete code coverage, please include details
regarding unit, and regression tests -->

### Testing Notes:

<!-- Attach any visual examples, or supporting evidence (attach any
.gif/video/console output below) -->
<!-- Merging Requirements:
- Please give your PR a title that is release-note friendly
- In order to be merged, you must add the most appropriate category
Label (Added, Changed, Fixed) to your PR
-->
<!-- Explain why this is an improvement (Does this add missing
functionality, improve performance, or reduce complexity?) -->

### Purpose:

<!-- Does this PR introduce a breaking change? -->

### Current Behavior:

### New Behavior:

<!-- As we aim for complete code coverage, please include details
regarding unit, and regression tests -->

### Testing Notes:

<!-- Attach any visual examples, or supporting evidence (attach any
.gif/video/console output below) -->
<!-- Merging Requirements:
- Please give your PR a title that is release-note friendly
- In order to be merged, you must add the most appropriate category
Label (Added, Changed, Fixed) to your PR
-->
<!-- Explain why this is an improvement (Does this add missing
functionality, improve performance, or reduce complexity?) -->

### Purpose:

<!-- Does this PR introduce a breaking change? -->

### Current Behavior:

### New Behavior:

<!-- As we aim for complete code coverage, please include details
regarding unit, and regression tests -->

### Testing Notes:

<!-- Attach any visual examples, or supporting evidence (attach any
.gif/video/console output below) -->
Make query use the table primary key, optimizing the runtime
significantly.
…long_lived_datalayer_merkle_blob_from_main_e5bf80e29f60dc507875b4742c50aa3d19364313
altendky and others added 21 commits July 11, 2025 22:35
…long_lived_datalayer_merkle_blob_from_main_dac837e79961fa5ce9611d5531d789211031c465
* DL code cleanup

* Lint.
* DL Check root hash in missing hashes.

* Poetry.

* Send root hash param.

* Switch branch.

* Use correct branch name.
* tidy

* Update test_data_rpc.py
* Cleanup keys/values db.

* Fix bug.

* Add test.

* Lint.

* Add test.

* Lint.

* Move unconfirmed blobs in memory.

* Lint.

* Apply suggestions from code review

Co-authored-by: Kyle Altendorf <[email protected]>

* Add field.

* functools too.

* Lint.

* Switch to context manager.

* Iterator.

* Ruff.

* Use context manager everywhere.

* Add test.

* Add test.

* Match exception.

* Apply suggestions from code review

Co-authored-by: Kyle Altendorf <[email protected]>

* Address review comments.

* Use context maanger.

* Revert.

* Revert further.

* Revert.

---------

Co-authored-by: Kyle Altendorf <[email protected]>
…long_lived_datalayer_merkle_blob_from_main_cac84b5e057a074da6a72e2a8bbcc70ec0a09668
…long_lived_datalayer_merkle_blob_from_main_ebf8105fc12c351888069ba399be6cf998f680e0
…long_lived_datalayer_merkle_blob_from_main_73cb54789be134e0e373960f73e1a6ba70d3a90f
…long_lived_datalayer_merkle_blob_from_main_3652e609bdcdb199ece68bcfd60665d19594e5f0
<!-- Merging Requirements:
- Please give your PR a title that is release-note friendly
- In order to be merged, you must add the most appropriate category
Label (Added, Changed, Fixed) to your PR
-->
<!-- Explain why this is an improvement (Does this add missing
functionality, improve performance, or reduce complexity?) -->

### Purpose:

side note, #19210 is
an exploration of what a permanent version of this might look like.

<!-- Does this PR introduce a breaking change? -->

### Current Behavior:

### New Behavior:

<!-- As we aim for complete code coverage, please include details
regarding unit, and regression tests -->

### Testing Notes:

<!-- Attach any visual examples, or supporting evidence (attach any
.gif/video/console output below) -->
…long_lived_datalayer_merkle_blob_from_main_eca97fa4c43f98e21613b20197b9e938a4676c98
…main_from_long_lived_datalayer_merkle_blob_eadce7954e10a649e402bb6a11d4987c938de796
@altendky altendky requested a review from a team as a code owner September 22, 2025 22:48
@altendky altendky added checkpoint_merge Changed Required label for PR that categorizes merge commit message as "Changed" for changelog labels Sep 22, 2025
Copy link
Contributor

Copy link

Pull Request Test Coverage Report for Build 17930586615

Details

  • 1095 of 1164 (94.07%) changed or added relevant lines in 13 files are covered.
  • 62 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.04%) to 91.127%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/data_layer/download_data.py 17 18 94.44%
chia/_tests/core/data_layer/test_data_store.py 352 354 99.44%
chia/data_layer/data_layer_util.py 24 27 88.89%
chia/cmds/dev/data.py 2 8 25.0%
chia/data_layer/util/benchmark.py 2 22 9.09%
chia/data_layer/data_store.py 627 664 94.43%
Files with Coverage Reduction New Missed Lines %
chia/daemon/client.py 1 74.16%
chia/daemon/keychain_proxy.py 1 70.57%
chia/data_layer/data_layer_errors.py 1 96.0%
chia/farmer/farmer.py 1 73.32%
chia/full_node/pending_tx_cache.py 1 96.55%
chia/rpc/rpc_server.py 1 88.09%
chia/wallet/util/wallet_sync_utils.py 1 85.57%
chia/timelord/timelord_launcher.py 2 89.29%
chia/wallet/wallet_node.py 3 87.13%
chia/data_layer/data_layer.py 4 85.71%
Totals Coverage Status
Change from base Build 17923354781: -0.04%
Covered Lines: 102485
Relevant Lines: 112296

💛 - Coveralls

@altendky altendky closed this Oct 6, 2025
@altendky altendky reopened this Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog checkpoint_merge coverage-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants