-
Notifications
You must be signed in to change notification settings - Fork 2.1k
catchup: into main from long_lived/datalayer_merkle_blob @ eadce7954e10a649e402bb6a11d4987c938de796 #20096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
altendky
wants to merge
342
commits into
main
Choose a base branch
from
catchup/main_from_long_lived_datalayer_merkle_blob_eadce7954e10a649e402bb6a11d4987c938de796
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,964
−2,676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kyle Altendorf <[email protected]>
<!-- Merging Requirements: - Please give your PR a title that is release-note friendly - In order to be merged, you must add the most appropriate category Label (Added, Changed, Fixed) to your PR --> <!-- Explain why this is an improvement (Does this add missing functionality, improve performance, or reduce complexity?) --> ### Purpose: <!-- Does this PR introduce a breaking change? --> ### Current Behavior: ### New Behavior: <!-- As we aim for complete code coverage, please include details regarding unit, and regression tests --> ### Testing Notes: <!-- Attach any visual examples, or supporting evidence (attach any .gif/video/console output below) -->
…long_lived_datalayer_merkle_blob_from_main_748c8cec8e24c0feabc10e8db22284dc3712180f
Co-authored-by: Kyle Altendorf <[email protected]>
<!-- Merging Requirements: - Please give your PR a title that is release-note friendly - In order to be merged, you must add the most appropriate category Label (Added, Changed, Fixed) to your PR --> <!-- Explain why this is an improvement (Does this add missing functionality, improve performance, or reduce complexity?) --> ### Purpose: <!-- Does this PR introduce a breaking change? --> ### Current Behavior: ### New Behavior: <!-- As we aim for complete code coverage, please include details regarding unit, and regression tests --> ### Testing Notes: <!-- Attach any visual examples, or supporting evidence (attach any .gif/video/console output below) -->
<!-- Merging Requirements: - Please give your PR a title that is release-note friendly - In order to be merged, you must add the most appropriate category Label (Added, Changed, Fixed) to your PR --> <!-- Explain why this is an improvement (Does this add missing functionality, improve performance, or reduce complexity?) --> ### Purpose: <!-- Does this PR introduce a breaking change? --> ### Current Behavior: ### New Behavior: <!-- As we aim for complete code coverage, please include details regarding unit, and regression tests --> ### Testing Notes: <!-- Attach any visual examples, or supporting evidence (attach any .gif/video/console output below) -->
<!-- Merging Requirements: - Please give your PR a title that is release-note friendly - In order to be merged, you must add the most appropriate category Label (Added, Changed, Fixed) to your PR --> <!-- Explain why this is an improvement (Does this add missing functionality, improve performance, or reduce complexity?) --> ### Purpose: <!-- Does this PR introduce a breaking change? --> ### Current Behavior: ### New Behavior: <!-- As we aim for complete code coverage, please include details regarding unit, and regression tests --> ### Testing Notes: <!-- Attach any visual examples, or supporting evidence (attach any .gif/video/console output below) -->
Make query use the table primary key, optimizing the runtime significantly.
…long_lived_datalayer_merkle_blob_from_main_e5bf80e29f60dc507875b4742c50aa3d19364313
…long_lived_datalayer_merkle_blob_from_main_dac837e79961fa5ce9611d5531d789211031c465
* DL code cleanup * Lint.
* DL Check root hash in missing hashes. * Poetry. * Send root hash param. * Switch branch. * Use correct branch name.
* Cleanup keys/values db. * Fix bug. * Add test. * Lint. * Add test. * Lint. * Move unconfirmed blobs in memory. * Lint. * Apply suggestions from code review Co-authored-by: Kyle Altendorf <[email protected]> * Add field. * functools too. * Lint. * Switch to context manager. * Iterator. * Ruff. * Use context manager everywhere. * Add test. * Add test. * Match exception. * Apply suggestions from code review Co-authored-by: Kyle Altendorf <[email protected]> * Address review comments. * Use context maanger. * Revert. * Revert further. * Revert. --------- Co-authored-by: Kyle Altendorf <[email protected]>
…long_lived_datalayer_merkle_blob_from_main_cac84b5e057a074da6a72e2a8bbcc70ec0a09668
…long_lived_datalayer_merkle_blob_from_main_ebf8105fc12c351888069ba399be6cf998f680e0
…long_lived_datalayer_merkle_blob_from_main_73cb54789be134e0e373960f73e1a6ba70d3a90f
…long_lived_datalayer_merkle_blob_from_main_3652e609bdcdb199ece68bcfd60665d19594e5f0
<!-- Merging Requirements: - Please give your PR a title that is release-note friendly - In order to be merged, you must add the most appropriate category Label (Added, Changed, Fixed) to your PR --> <!-- Explain why this is an improvement (Does this add missing functionality, improve performance, or reduce complexity?) --> ### Purpose: side note, #19210 is an exploration of what a permanent version of this might look like. <!-- Does this PR introduce a breaking change? --> ### Current Behavior: ### New Behavior: <!-- As we aim for complete code coverage, please include details regarding unit, and regression tests --> ### Testing Notes: <!-- Attach any visual examples, or supporting evidence (attach any .gif/video/console output below) -->
…long_lived_datalayer_merkle_blob_from_main_eca97fa4c43f98e21613b20197b9e938a4676c98
…main_from_long_lived_datalayer_merkle_blob_eadce7954e10a649e402bb6a11d4987c938de796
|
Pull Request Test Coverage Report for Build 17930586615Details
💛 - Coveralls |
emlowe
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
checkpoint_merge
coverage-diff
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source hash: eadce79
Remaining commits: 0