CHIA-3758 Avoid recomputing mempool removals' transaction IDs in FullNode's broadcast_removed_tx #20097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
We have access to it already when we construct
removed_internal_items
so just pass it as part ofMempoolRemoveInfo
'sitems
.Current Behavior:
We recompute mempool removals' transaction IDs in
FullNode
'sbroadcast_removed_tx
.New Behavior:
We access transaction IDs directly without recomputing them.
Testing Notes: