Skip to content

Conversation

AmineKhaldi
Copy link
Contributor

Purpose:

We have access to it already when we construct removed_internal_items so just pass it as part of MempoolRemoveInfo's items.

Current Behavior:

We recompute mempool removals' transaction IDs in FullNode's broadcast_removed_tx.

New Behavior:

We access transaction IDs directly without recomputing them.

Testing Notes:

@AmineKhaldi AmineKhaldi self-assigned this Sep 23, 2025
@AmineKhaldi AmineKhaldi added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Sep 23, 2025
Copy link

Pull Request Test Coverage Report for Build 17944281720

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 22 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.008%) to 91.161%

Files with Coverage Reduction New Missed Lines %
chia/daemon/client.py 1 74.16%
chia/daemon/keychain_proxy.py 1 70.57%
chia/farmer/farmer.py 1 73.32%
chia/full_node/pending_tx_cache.py 1 96.55%
chia/rpc/rpc_server.py 1 88.09%
chia/wallet/util/wallet_sync_utils.py 1 85.57%
chia/timelord/timelord_launcher.py 2 89.29%
chia/wallet/wallet_node.py 3 87.2%
chia/timelord/timelord.py 11 71.94%
Totals Coverage Status
Change from base Build 17923354781: -0.008%
Covered Lines: 102743
Relevant Lines: 112544

💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review September 23, 2025 17:29
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner September 23, 2025 17:29
@pmaslana pmaslana merged commit f7b7c66 into Chia-Network:main Sep 24, 2025
345 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants