Skip to content

Conversation

AmineKhaldi
Copy link
Contributor

Purpose:

Instead of holding a SpendBundle in a MempoolItem, just construct it on-demand from the coin spends and the aggregate signature.

Current Behavior:

We hold coin spends in both spend_bundle and bundle_coin_spends.

New Behavior:

We hold coin spends in bundle_coin_spends and we construct the spend bundle from that and the aggregate signature.

@AmineKhaldi AmineKhaldi self-assigned this Sep 30, 2025
@AmineKhaldi AmineKhaldi added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Sep 30, 2025
Copy link

Pull Request Test Coverage Report for Build 18127910299

Details

  • 36 of 36 (100.0%) changed or added relevant lines in 8 files are covered.
  • 18 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.003%) to 91.15%

Files with Coverage Reduction New Missed Lines %
chia/full_node/pending_tx_cache.py 1 96.55%
chia/wallet/util/wallet_sync_utils.py 1 85.57%
chia/consensus/blockchain.py 2 94.38%
chia/rpc/rpc_server.py 2 89.03%
chia/server/node_discovery.py 2 82.11%
chia/wallet/wallet_node.py 4 87.13%
chia/full_node/full_node.py 6 87.27%
Totals Coverage Status
Change from base Build 18104177433: 0.003%
Covered Lines: 102867
Relevant Lines: 112693

💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review October 1, 2025 09:48
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner October 1, 2025 09:48
arvidn
arvidn previously approved these changes Oct 1, 2025
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants