testing a thing

.github/workflows/check_wheel_availability.yaml

@@ -43,7 +43,7 @@ jobs:
             matrix: arm
           - name: Intel
             matrix: intel
-        python-version: ["3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.10", "3.11", "3.12"]
         exclude:
           - os:
               matrix: windows

.github/workflows/pre-commit.yml

@@ -41,7 +41,6 @@ jobs:
           - name: Intel
             matrix: intel
         python:
-          - major_dot_minor: "3.9"
           - major_dot_minor: "3.10"
           - major_dot_minor: "3.11"
           - major_dot_minor: "3.12"
@@ -67,6 +66,8 @@ jobs:
           git config --global core.autocrlf false
 
       - uses: actions/checkout@v5
+        with:
+          fetch-depth: 0
 
       - uses: Chia-Network/actions/setup-python@main
         with:

.github/workflows/test-install-scripts.yml

@@ -214,7 +214,9 @@ jobs:
       - name: Prepare Amazon Linux
         if: ${{ matrix.distribution.type == 'amazon' }}
         run: |
-          yum install --assumeyes git
+          dnf update -y
+          dnf search python3.12
+          dnf install git python3.12 -y
 
       - name: Prepare Arch
         if: ${{ matrix.distribution.type == 'arch' }}
@@ -242,7 +244,9 @@ jobs:
       - name: Prepare Rocky
         if: ${{ matrix.distribution.type == 'rocky' }}
         run: |
-          yum install --assumeyes git python39
+          dnf update -y
+          dnf search python3.12
+          dnf install git python3.12 -y
 
       - name: Prepare Ubuntu
         if: ${{ matrix.distribution.type == 'ubuntu' }}
@@ -251,7 +255,7 @@ jobs:
         run: |
           apt-get --yes update
           apt-get install --yes git lsb-release
-          MINIMUM=3.9
+          MINIMUM=3.10
           if ! apt-get satisfy --yes "python3-venv (>= ${MINIMUM})"
           then
             apt-get install --yes python${MINIMUM}-venv

.github/workflows/test-single.yml

@@ -70,15 +70,6 @@ jobs:
           - matrix: ${{ inputs.arch }}
             emoji: ${{ inputs.arch-emoji }}
         python:
-          - name: "3.9"
-            file_name: "3.9"
-            action: "3.9"
-            apt: "3.9"
-            install_sh: "3.9"
-            matrix: "3.9"
-            exclude_from:
-              limited: True
-              main: True
           - name: "3.10"
             file_name: "3.10"
             action: "3.10"

.github/workflows/upload-pypi-source.yml

@@ -59,7 +59,6 @@ jobs:
             emoji: 🌀
             matrix: intel
         python:
-          - major_dot_minor: "3.9"
           - major_dot_minor: "3.10"
           - major_dot_minor: "3.11"
           - major_dot_minor: "3.12"

.pre-commit-config.yaml

@@ -40,9 +40,10 @@ repos:
     hooks:
       - id: poetry
         name: poetry
-        entry: ./activated.py --poetry poetry check --strict
+        entry: ./activated.py --poetry python poetry-check.py
         language: system
         pass_filenames: false
+        files: "^(poetry.lock|poetry.toml|pyproject.toml)$"
   - repo: https://github.com/pre-commit/mirrors-prettier
     rev: v3.1.0
     hooks:

Install.ps1

@@ -46,7 +46,7 @@ if ($null -eq (Get-Command py -ErrorAction SilentlyContinue))
     Exit 1
 }
 
-$supportedPythonVersions = "3.12", "3.11", "3.10", "3.9"
+$supportedPythonVersions = "3.12", "3.11", "3.10"
 if ("$env:INSTALL_PYTHON_VERSION" -ne "")
 {
     $pythonVersion = $env:INSTALL_PYTHON_VERSION

README.md

@@ -20,7 +20,7 @@ Chia is a modern cryptocurrency built from scratch, designed to be efficient, de
 
 Please check out the [Chia website][link-chia], the [Intro to Chia][link-intro], and [FAQ][link-faq] for information on this project.
 
-Python 3.9+ is required. Make sure your default python version is >=3.9 by typing `python3`.
+Python 3.10+ is required. Make sure your default python version is >=3.10 by typing `python3`.
 
 If you are behind a NAT, it can be difficult for peers outside your subnet to reach you when they start up. You can enable [UPnP][link-upnp]
 on your router or add a NAT (for IPv4 but not IPv6) and firewall rules to allow TCP port 8444 access to your peer.

chia/_tests/cmds/test_dev_gh.py

@@ -114,7 +114,7 @@ async def test_successfully_dispatches(
         assert by_name["macos-intel"]["conclusion"] == "skipped"
         assert by_name["windows"]["conclusion"] == "skipped"
 
-        versions = ["3.9", "3.10", "3.11", "3.12"]
+        versions = ["3.10", "3.11", "3.12"]
         runs_by_name: dict[str, list[str]] = {name: [] for name in ["ubuntu", "macos-arm"]}
         for name in by_name:
             platform, _, rest = name.partition(" / ")

chia/_tests/util/test_priority_mutex.py

@@ -381,7 +381,7 @@ def sane(requests: list[Request]) -> bool:
         return False
 
     ordered = sorted(requests)
-    return all(a.before(b) for a, b in zip(ordered, ordered[1:]))
+    return all(a.before(b) for a, b in itertools.pairwise(ordered))
 
 
 @dataclass

chia/cmds/cmd_classes.py

@@ -5,7 +5,6 @@
 import dataclasses
 import inspect
 import pathlib
-import sys
 from dataclasses import MISSING, dataclass, field, fields
 from typing import (
     Any,
@@ -45,20 +44,14 @@ async def run(self) -> None: ...
 
 
 def option(*param_decls: str, **kwargs: Any) -> Any:
-    if sys.version_info >= (3, 10):
-        default_default = MISSING
-    else:  # versions < 3.10 don't know about kw_only and they complain about lacks of defaults
-        # Can't get coverage on this because we only test on one version
-        default_default = None  # pragma: no cover
-
     return field(
         metadata=dict(
             option_args=dict(
                 param_decls=tuple(param_decls),
                 **kwargs,
             ),
         ),
-        default=kwargs.get("default", default_default),
+        default=kwargs.get("default", MISSING),
     )
 
 
@@ -270,16 +263,10 @@ def chia_command(
     def _chia_command(cls: type[ChiaCommand]) -> type[ChiaCommand]:
         # The type ignores here are largely due to the fact that the class information is not preserved after being
         # passed through the dataclass wrapper.  Not sure what to do about this right now.
-        if sys.version_info >= (3, 10):
-            wrapped_cls: type[ChiaCommand] = dataclass(
-                frozen=True,
-                kw_only=True,
-            )(cls)
-        else:  # pragma: no cover
-            # stuff below 3.10 doesn't know about kw_only
-            wrapped_cls: type[ChiaCommand] = dataclass(
-                frozen=True,
-            )(cls)
+        wrapped_cls: type[ChiaCommand] = dataclass(
+            frozen=True,
+            kw_only=True,
+        )(cls)
 
         metadata = Metadata(
             command=click.command(
@@ -316,9 +303,6 @@ def get_chia_command_metadata(cls: type[ChiaCommand]) -> Metadata:
 
 @dataclass_transform(frozen_default=True)
 def command_helper(cls: type[Any]) -> type[Any]:
-    if sys.version_info >= (3, 10):
-        new_cls = dataclass(frozen=True, kw_only=True)(cls)
-    else:  # stuff below 3.10 doesn't support kw_only
-        new_cls = dataclass(frozen=True)(cls)  # pragma: no cover
+    new_cls = dataclass(frozen=True, kw_only=True)(cls)
     setattr(new_cls, COMMAND_HELPER_ATTRIBUTE_NAME, True)
     return new_cls

chia/wallet/conditions.py

@@ -1472,9 +1472,7 @@ def parse_timelock_info(conditions: Iterable[Condition]) -> ConditionValidTimes:
         elif isinstance(condition, Timelock):
             timelock = condition
         else:
-            # Something about python 3.9 makes this be not covered but on 3.10+ it is covered
-            # https://github.com/nedbat/coveragepy/issues/1530
-            continue  # pragma: no cover
+            continue
 
         properties_left = properties.copy()
         min_not_max: bool = True

chia/wallet/wallet_request_types.py

@@ -1,13 +1,12 @@
 from __future__ import annotations
 
-import sys
 from dataclasses import dataclass, field
 from typing import Any, BinaryIO, Optional, final
 
 from chia_rs import Coin, G1Element, G2Element, PrivateKey
 from chia_rs.sized_bytes import bytes32
 from chia_rs.sized_ints import uint8, uint16, uint32, uint64
-from typing_extensions import Self, dataclass_transform
+from typing_extensions import Self
 
 from chia.data_layer.data_layer_wallet import Mirror
 from chia.data_layer.singleton_record import SingletonRecord
@@ -40,14 +39,6 @@
 from chia.wallet.wallet_spend_bundle import WalletSpendBundle
 
 
-@dataclass_transform(frozen_default=True, kw_only_default=True)
-def kw_only_dataclass(cls: type[Any]) -> type[Any]:
-    if sys.version_info >= (3, 10):
-        return dataclass(frozen=True, kw_only=True)(cls)
-    else:
-        return dataclass(frozen=True)(cls)  # pragma: no cover
-
-
 def default_raise() -> Any:  # pragma: no cover
     raise RuntimeError("This should be impossible to hit and is just for < 3.10 compatibility")
 
@@ -241,7 +232,7 @@ class GetWalletBalances(Streamable):
 
 # utility for GetWalletBalanceResponse(s)
 @streamable
-@kw_only_dataclass
+@dataclass(frozen=True, kw_only=True)
 class BalanceResponse(Balance):
     wallet_id: uint32 = field(default_factory=default_raise)
     wallet_type: uint8 = field(default_factory=default_raise)
@@ -1236,7 +1227,7 @@ class ExecuteSigningInstructionsResponse(Streamable):
 # field(default_factory=default_raise)
 # (this is for < 3.10 compatibility)
 @streamable
-@kw_only_dataclass
+@dataclass(frozen=True, kw_only=True)
 class TransactionEndpointRequest(Streamable):
     fee: uint64 = uint64(0)
     push: Optional[bool] = None
@@ -1357,7 +1348,7 @@ class PushTransactionsResponse(TransactionEndpointResponse):
 
 
 @streamable
-@kw_only_dataclass
+@dataclass(frozen=True, kw_only=True)
 class SplitCoins(TransactionEndpointRequest):
     wallet_id: uint32 = field(default_factory=default_raise)
     number_of_coins: uint16 = field(default_factory=default_raise)
@@ -1372,7 +1363,7 @@ class SplitCoinsResponse(TransactionEndpointResponse):
 
 
 @streamable
-@kw_only_dataclass
+@dataclass(frozen=True, kw_only=True)
 class CombineCoins(TransactionEndpointRequest):
     wallet_id: uint32 = field(default_factory=default_raise)
     number_of_coins: uint16 = uint16(500)
@@ -1389,7 +1380,7 @@ class CombineCoinsResponse(TransactionEndpointResponse):
 
 
 @streamable
-@kw_only_dataclass
+@dataclass(frozen=True, kw_only=True)
 class DIDMessageSpend(TransactionEndpointRequest):
     wallet_id: uint32 = field(default_factory=default_raise)
     coin_announcements: list[bytes] = field(default_factory=list)
@@ -1403,7 +1394,7 @@ class DIDMessageSpendResponse(TransactionEndpointResponse):
 
 
 @streamable
-@kw_only_dataclass
+@dataclass(frozen=True, kw_only=True)
 class DIDUpdateMetadata(TransactionEndpointRequest):
     wallet_id: uint32 = field(default_factory=default_raise)
     metadata: dict[str, str] = field(default_factory=dict)
@@ -1417,7 +1408,7 @@ class DIDUpdateMetadataResponse(TransactionEndpointResponse):
 
 
 @streamable
-@kw_only_dataclass
+@dataclass(frozen=True, kw_only=True)
 class DIDTransferDID(TransactionEndpointRequest):
     wallet_id: uint32 = field(default_factory=default_raise)
     inner_address: str = field(default_factory=default_raise)
@@ -1437,7 +1428,7 @@ class DIDTransferDIDResponse(TransactionEndpointResponse):
 
 
 @streamable
-@kw_only_dataclass
+@dataclass(frozen=True, kw_only=True)
 class NFTMintNFTRequest(TransactionEndpointRequest):
     wallet_id: uint32 = field(default_factory=default_raise)
     royalty_address: Optional[str] = field(default_factory=default_raise)
@@ -1463,7 +1454,7 @@ class NFTMintNFTResponse(TransactionEndpointResponse):
 
 
 @streamable
-@kw_only_dataclass
+@dataclass(frozen=True, kw_only=True)
 class NFTSetNFTDID(TransactionEndpointRequest):
     wallet_id: uint32 = field(default_factory=default_raise)
     nft_coin_id: bytes32 = field(default_factory=default_raise)
@@ -1478,7 +1469,7 @@ class NFTSetNFTDIDResponse(TransactionEndpointResponse):
 
 
 @streamable
-@kw_only_dataclass
+@dataclass(frozen=True, kw_only=True)
 class NFTSetDIDBulk(TransactionEndpointRequest):
     nft_coin_list: list[NFTCoin] = field(default_factory=default_raise)
     did_id: Optional[str] = None
@@ -1493,7 +1484,7 @@ class NFTSetDIDBulkResponse(TransactionEndpointResponse):
 
 
 @streamable
-@kw_only_dataclass
+@dataclass(frozen=True, kw_only=True)
 class NFTTransferBulk(TransactionEndpointRequest):
     nft_coin_list: list[NFTCoin] = field(default_factory=default_raise)
     target_address: str = field(default_factory=default_raise)
@@ -1508,7 +1499,7 @@ class NFTTransferBulkResponse(TransactionEndpointResponse):
 
 
 @streamable
-@kw_only_dataclass
+@dataclass(frozen=True, kw_only=True)
 class CreateNewDL(TransactionEndpointRequest):
     root: bytes32 = field(default_factory=default_raise)
 
@@ -1520,7 +1511,7 @@ class CreateNewDLResponse(TransactionEndpointResponse):
 
 
 @streamable
-@kw_only_dataclass
+@dataclass(frozen=True, kw_only=True)
 class DLUpdateRoot(TransactionEndpointRequest):
     launcher_id: bytes32 = field(default_factory=default_raise)
     new_root: bytes32 = field(default_factory=default_raise)
@@ -1564,7 +1555,7 @@ def from_json_dict(cls, json_dict: dict[str, Any]) -> Self:
 
 
 @streamable
-@kw_only_dataclass
+@dataclass(frozen=True, kw_only=True)
 class DLUpdateMultiple(TransactionEndpointRequest):
     updates: DLUpdateMultipleUpdates = field(default_factory=default_raise)
 
@@ -1580,7 +1571,7 @@ class DLUpdateMultipleResponse(TransactionEndpointResponse):
 
 
 @streamable
-@kw_only_dataclass
+@dataclass(frozen=True, kw_only=True)
 class DLNewMirror(TransactionEndpointRequest):
     launcher_id: bytes32 = field(default_factory=default_raise)
     amount: uint64 = field(default_factory=default_raise)
@@ -1594,7 +1585,7 @@ class DLNewMirrorResponse(TransactionEndpointResponse):
 
 
 @streamable
-@kw_only_dataclass
+@dataclass(frozen=True, kw_only=True)
 class DLDeleteMirror(TransactionEndpointRequest):
     coin_id: bytes32 = field(default_factory=default_raise)