block header validation

[arvidn]

Purpose:

The test for validate_finished_block_header() will need to be extended to run for hard-fork 3.0 consensus mode, and to cover PoS 2. This is a small step in simplifying it, preparing to extend it in the future.

Many lines are de-indented by this change, so reviewing commits one at a time and ignoring white space is recommended.

[coveralls-official]

Pull Request Test Coverage Report for Build 18566257410

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 46 of 46 (100.0%) changed or added relevant lines in 1 file are covered.
• 35 unchanged lines in 4 files lost coverage.
• Overall coverage decreased (-0.01%) to 90.812%

---

Files with Coverage Reduction	New Missed Lines	%
chia/server/server.py	3	84.96%
chia/_tests/util/full_sync.py	3	88.14%
chia/server/address_manager.py	9	92.58%
chia/server/node_discovery.py	20	78.53%

Totals
Change from base Build 18544726493:	-0.01%
Covered Lines:	102239
Relevant Lines:	112426

---

💛 - Coveralls

[wjblanke]

aok