Skip to content

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Oct 16, 2025

Purpose:

This PR bumps the chia_rs dependency to the latest version. The first commit is limited to updating the version and updating usage of it accordingly. The second PR updates the V2Prover class to use the new functionality exposed by chia_rs.

It's recommended to review the commits separately.

Current Behavior:

  • plot strength schedule is used
  • There's no schedule for v2 plot filter
  • partial proofs are expected to be bytes
  • the prover API is assumed to get partial proofs directly from the plot, and then qualities from the partial proof

New Behavior:

  • plot strength schedule has been removed
  • There's a new plot filter schedule for v2 plots
  • partial proofs are list[uint64], and sometimes need to be serialized to form a key for a dictionary
  • the prover API gets qualities from the plot, and only if they pass the difficulty do we request the remaining bits to form the partial proof
  • The V2Prover class can now load v2 plots

@arvidn arvidn requested a review from a team as a code owner October 16, 2025 19:51
@arvidn arvidn added the Added Required label for PR that categorizes merge commit message as "Added" for changelog label Oct 16, 2025
@arvidn arvidn requested a review from almogdepaz October 16, 2025 19:59
@arvidn
Copy link
Contributor Author

arvidn commented Oct 17, 2025

most of the uncovered lines will be covered once we've completed support for v2 plots, and have the test plots and test chains in place

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Oct 17, 2025
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Oct 17, 2025
Copy link
Contributor

File Coverage Missing Lines
chia/_tests/harvester/test_harvester_api.py 54.5% lines 94-98
chia/harvester/harvester_api.py 40.0% lines 165, 170, 188, 199-200, 202-203, 205-206
chia/plotting/check_plots.py 0.0% lines 10, 12, 18, 180, 208, 212, 214, 217-219, 221-223
chia/plotting/prover.py 62.5% lines 49, 62, 66, 69, 72, 75, 78, 81, 91, 94, 97, 100, 127, 157, 166
chia/simulator/block_tools.py 42.9% lines 1516-1517, 1519-1520, 1524, 1548-1554
chia/solver/solver_api.py 75.0% lines 58
Total Missing Coverage
176 lines 55 lines 68%

Copy link

Pull Request Test Coverage Report for Build 18604981706

Details

  • 121 of 176 (68.75%) changed or added relevant lines in 17 files are covered.
  • 26 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.04%) to 90.808%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/solver/solver_api.py 3 4 75.0%
chia/_tests/harvester/test_harvester_api.py 6 11 54.55%
chia/harvester/harvester_api.py 6 15 40.0%
chia/simulator/block_tools.py 9 21 42.86%
chia/plotting/check_plots.py 0 13 0.0%
chia/plotting/prover.py 25 40 62.5%
Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node_api.py 1 85.95%
chia/full_node/full_node.py 1 87.13%
chia/plotting/check_plots.py 1 0.0%
chia/_tests/simulation/test_simulation.py 1 96.47%
chia/plotting/prover.py 2 81.05%
chia/_tests/core/test_farmer_harvester_rpc.py 2 98.08%
chia/_tests/core/util/test_lockfile.py 3 88.89%
chia/wallet/wallet_node.py 3 86.91%
chia/server/node_discovery.py 5 79.96%
chia/server/address_manager.py 7 92.84%
Totals Coverage Status
Change from base Build 18601081112: -0.04%
Covered Lines: 102254
Relevant Lines: 112446

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Added Required label for PR that categorizes merge commit message as "Added" for changelog coverage-diff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant