Skip to content

Conversation

hoffmang9
Copy link
Member

Hint how to format the ipv6 address on the command line

Purpose:

It is not entirely clear what the proper method of handing an ipv6:port is on the command line. Extending this error message gives the user a solid hint on how to do it appropriately. Also updated the v4 example to hint the correct port of 8444 since that's what most nodes are on.

Current Behavior:

Everything works as expected, but it's hard to find documentation re ipv6

New Behavior:

Error message explains both ipv4 and ipv6

Testing Notes:

Manually tested that the ipv6 address is being correctly parsed by urlsplit(). The example v6 address is currently node.chia.net. Also manually confirmed that my ipv6 farm could add my other ipv6 farm in [ipv6]:8444 form.

Hint how to format the ipv6 address on the command line
@hoffmang9 hoffmang9 requested a review from a team as a code owner October 17, 2025 22:15
@hoffmang9 hoffmang9 added documentation Improvements or additions to documentation CLI ready_to_review Added Required label for PR that categorizes merge commit message as "Added" for changelog labels Oct 17, 2025
@hoffmang9 hoffmang9 changed the title Update error message for invalid IP and port format Update error message for invalid IP and port format to clarify ipv6 Oct 17, 2025
Copy link
Contributor

File Coverage Missing Lines
chia/cmds/peer_funcs.py 0.0% lines 23
Total Missing Coverage
Unknown Unknown 0%

Copy link

Pull Request Test Coverage Report for Build 18606105192

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 38 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.828%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/cmds/peer_funcs.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node_api.py 1 85.95%
chia/_tests/simulation/test_simulation.py 1 96.47%
chia/_tests/core/test_farmer_harvester_rpc.py 2 98.08%
chia/server/node_discovery.py 3 80.32%
chia/timelord/timelord.py 3 71.62%
chia/full_node/full_node.py 4 86.85%
chia/_tests/core/util/test_lockfile.py 24 77.31%
Totals Coverage Status
Change from base Build 18601081112: -0.02%
Covered Lines: 102288
Relevant Lines: 112461

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Added Required label for PR that categorizes merge commit message as "Added" for changelog CLI coverage-diff documentation Improvements or additions to documentation ready_to_review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants