Simplified member access (#8422)

Author: glen-84

.editorconfig

@@ -188,6 +188,8 @@ dotnet_diagnostic.CA1805.severity = warning
 dotnet_diagnostic.RCS1129.severity = none
 # Simplify name.
 dotnet_diagnostic.IDE0001.severity = warning
+# Simplify member access.
+dotnet_diagnostic.IDE0002.severity = warning
 # Remove unnecessary cast.
 dotnet_diagnostic.IDE0004.severity = warning
 # Remove unnecessary using directives.

src/GreenDonut/test/GreenDonut.Tests/DataLoaderTests.cs

@@ -161,7 +161,7 @@ public async Task LoadParamsKeysNull()
     public async Task LoadParamsZeroKeys()
     {
         // arrange
-        var fetch = TestHelpers.CreateFetch<string, string>();
+        var fetch = CreateFetch<string, string>();
         var batchScheduler = new ManualBatchScheduler();
         var loader = new DataLoader<string, string>(fetch, batchScheduler, new DataLoaderOptions());
         var keys = Array.Empty<string>();
@@ -179,8 +179,8 @@ public async Task LoadParamsZeroKeys()
     public async Task LoadParamsResult()
     {
         // arrange
-        var fetch = TestHelpers
-            .CreateFetch<string, string>("Bar");
+        var fetch =
+            CreateFetch<string, string>("Bar");
         var batchScheduler = new ManualBatchScheduler();
         var loader = new DataLoader<string, string>(fetch, batchScheduler, new DataLoaderOptions());
         var keys = new[] { "Foo" };

src/HotChocolate/Core/src/Types/Internal/ExtendedType.Members.cs

@@ -95,7 +95,7 @@ private static ExtendedType Rewrite(
                     }
                 }
 
-                elementType ??= ExtendedType.FromType(itemType, cache);
+                elementType ??= FromType(itemType, cache);
             }
 
             if (extendedType.IsArray && elementType is null)

src/HotChocolate/Core/src/Validation/Rules/ValueVisitor.cs

@@ -442,7 +442,7 @@ private static bool IsInstanceOfType(
         {
             for (var i = 0; i < list.Items.Count; i++)
             {
-                if (!ValueVisitor.IsInstanceOfType(context, elementType, list.Items[i]))
+                if (!IsInstanceOfType(context, elementType, list.Items[i]))
                 {
                     return false;
                 }

src/HotChocolate/Core/test/Validation.Tests/DocumentValidatorTests.cs

@@ -733,7 +733,7 @@ .. document.Definitions.Skip(1),
     [Fact]
     public void Ensure_That_Merged_Fields_Are_Not_In_Violation_Of_Duplicate_Directives_Rule()
     {
-        DocumentValidatorTests.ExpectValid(
+        ExpectValid(
             """
             query ($a: Boolean!) {
                 dog {

src/HotChocolate/Core/test/Validation.Tests/Types/ComplexDirective.cs

@@ -12,7 +12,7 @@ protected override void Configure(
 
         descriptor.Name("complex");
 
-        descriptor.Location(HotChocolate.Types.DirectiveLocation.Field);
+        descriptor.Location(DirectiveLocation.Field);
 
         descriptor.Argument("anyArg")
             .Type<AnyType>();

src/HotChocolate/Data/src/Data/Filters/Visitor/FilterProvider.cs

@@ -59,7 +59,7 @@ void IFilterProviderConvention.Initialize(
         IFilterConvention convention)
     {
         _filterConvention = convention;
-        base.Initialize(context);
+        Initialize(context);
     }
 
     void IFilterProviderConvention.Complete(IConventionContext context)

src/HotChocolate/Data/src/Data/Filters/Visitor/FilterProviderExtensions.cs

@@ -26,7 +26,7 @@ void IFilterProviderConvention.Initialize(
         IConventionContext context,
         IFilterConvention convention)
     {
-        base.Initialize(context);
+        Initialize(context);
     }
 
     void IFilterProviderConvention.Complete(IConventionContext context)

src/HotChocolate/Data/src/Data/Projections/Convention/ProjectionProviderExtension.cs

@@ -22,7 +22,7 @@ public ProjectionProviderExtension(Action<IProjectionProviderDescriptor> configu
 
     void IProjectionProviderConvention.Initialize(IConventionContext context)
     {
-        base.Initialize(context);
+        Initialize(context);
     }
 
     void IProjectionProviderConvention.Complete(IConventionContext context)

src/HotChocolate/Data/src/Data/Sorting/Visitor/SortProviderExtensions.cs

@@ -24,7 +24,7 @@ protected SortProviderExtensions(Action<ISortProviderDescriptor<TContext>> confi
 
     void ISortProviderConvention.Initialize(IConventionContext context, ISortConvention convention)
     {
-        base.Initialize(context);
+        Initialize(context);
     }
 
     void ISortProviderConvention.Complete(IConventionContext context)