Removed unnecessary initialization (#8392)

Author: glen-84

.editorconfig

@@ -167,6 +167,9 @@ dotnet_diagnostic.CA1511.severity = warning
 dotnet_diagnostic.CA1512.severity = warning
 # Use ObjectDisposedException throw helper.
 dotnet_diagnostic.CA1513.severity = warning
+# Do not initialize unnecessarily.
+dotnet_diagnostic.CA1805.severity = warning
+dotnet_diagnostic.RCS1129.severity = none
 # Remove unnecessary cast.
 dotnet_diagnostic.IDE0004.severity = warning
 # Remove unnecessary using directives.

src/HotChocolate/AspNetCore/src/AspNetCore/GraphQLServerOptions.cs

@@ -29,7 +29,7 @@ public sealed class GraphQLServerOptions
     /// <summary>
     /// Defines if GraphQL HTTP GET requests are allowed.
     /// </summary>
-    public bool EnforceGetRequestsPreflightHeader { get; set; } = false;
+    public bool EnforceGetRequestsPreflightHeader { get; set; }
 
     /// <summary>
     /// Defines if GraphQL HTTP Multipart requests are allowed.

src/HotChocolate/Core/test/Execution.Tests/Instrumentation/DiagnosticListenerTests.cs

@@ -70,7 +70,7 @@ public async Task Intercept_Resolver_Result_With_Multiple_Listener()
 
     public class Touched
     {
-        public bool Signal = false;
+        public bool Signal;
     }
 
     private class TouchedListener : ExecutionDiagnosticEventListener

src/HotChocolate/Core/test/Fetching.Tests/AutoCacheDataLoaderTests.cs

@@ -87,7 +87,7 @@ protected override Task<Cat> LoadSingleAsync(string key, CancellationToken cance
 
     public static class CounterStore
     {
-        private static int s_catCounter = 0;
+        private static int s_catCounter;
 
         public static int GetNextCatCount() => Interlocked.Increment(ref s_catCounter);
     }

src/HotChocolate/Core/test/Subscriptions.Tests/DefaultTopicTests.cs

@@ -71,7 +71,7 @@ protected override ValueTask<IDisposable> OnConnectAsync(CancellationToken cance
 
     private class StubDisposableSession : IDisposable
     {
-        public bool DisposableCalled { get; private set; } = false;
+        public bool DisposableCalled { get; private set; }
 
         public void Dispose()
         {
@@ -81,7 +81,7 @@ public void Dispose()
 
     private class StubAsyncDisposableSession : StubDisposableSession, IAsyncDisposable
     {
-        public bool AsyncDisposableCalled { get; private set; } = false;
+        public bool AsyncDisposableCalled { get; private set; }
 
         public ValueTask DisposeAsync()
         {

src/HotChocolate/Core/test/Types.Tests/Configuration/TypeDiscoveryTests.cs

@@ -174,6 +174,6 @@ public class QueryTypeWithCustomLocalDate
 
     public class LocalDate
     {
-        public DateOnly Date { get; set; } = new();
+        public DateOnly Date { get; set; }
     }
 }

src/HotChocolate/Core/test/Types.Tests/Types/Descriptors/Conventions/DefaultTypeInspectorTests.cs

@@ -764,7 +764,7 @@ public class DoNotInfer
 
         public void ReturnsVoid() { }
 
-        public object ObjectProp { get; } = null;
+        public object ObjectProp { get; }
 
         public string ByRefParameter(ref string s) => s;
 

src/HotChocolate/Core/test/Types.Tests/Types/InputParserTests.cs

@@ -564,6 +564,6 @@ public class Test4Input
     {
         public string Field1 { get; set; } = null!;
 
-        public int Field2 { get; set; } = 0;
+        public int Field2 { get; set; }
     }
 }

src/HotChocolate/CostAnalysis/src/CostAnalysis/CostMetrics.cs

@@ -4,8 +4,8 @@ namespace HotChocolate.CostAnalysis;
 public sealed record CostMetrics
 {
     /// <summary>https://ibm.github.io/graphql-specs/cost-spec.html#sec-Field-Cost</summary>
-    public double FieldCost { get; init; } = 0;
+    public double FieldCost { get; init; }
 
     /// <summary>https://ibm.github.io/graphql-specs/cost-spec.html#sec-Type-Cost</summary>
-    public double TypeCost { get; init; } = 0;
+    public double TypeCost { get; init; }
 }

src/HotChocolate/CostAnalysis/src/CostAnalysis/Options/CostOptions.cs

@@ -5,7 +5,7 @@ namespace HotChocolate.CostAnalysis;
 /// </summary>
 public sealed class CostOptions
 {
-    private bool _skipAnalyzer = false;
+    private bool _skipAnalyzer;
     private bool _enforceCostLimits = true;
 
     /// <summary>