Updated code to use the ArgumentOutOfRangeException throw helper (#8321)

Author: glen-84

.editorconfig

@@ -150,11 +150,14 @@ dotnet_naming_symbols.static_fields.applicable_accessibilities = private, intern
 dotnet_naming_style.static_prefix_style.required_prefix = s_
 dotnet_naming_style.static_prefix_style.capitalization = camel_case
 
-# Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance.
+# Use ArgumentNullException throw helper.
 dotnet_diagnostic.CA1510.severity = warning
-# Use 'ArgumentException.ThrowIfNullOrEmpty' instead of explicitly throwing a new exception instance.
+# Use ArgumentException throw helper.
 dotnet_diagnostic.CA1511.severity = warning
+# Use ArgumentOutOfRangeException throw helper.
+dotnet_diagnostic.CA1512.severity = warning
 
 [src/HotChocolate/Language/**/*.cs]
 dotnet_diagnostic.CA1510.severity = none
 dotnet_diagnostic.CA1511.severity = none
+dotnet_diagnostic.CA1512.severity = none

src/HotChocolate/Core/src/Execution.Abstractions/IndexerPathSegment.cs

@@ -9,10 +9,7 @@ public sealed class IndexerPathSegment : Path
     internal IndexerPathSegment(Path parent, int index)
         : base(parent)
     {
-        if (index < 0)
-        {
-            throw new ArgumentOutOfRangeException(nameof(index));
-        }
+        ArgumentOutOfRangeException.ThrowIfNegative(index);
 
         Index = index;
     }

src/HotChocolate/Core/src/Execution/Processing/Result/ResultData.cs

@@ -45,10 +45,7 @@ public abstract class ResultData
     /// </param>
     public void SetParent(ResultData parent, int index)
     {
-        if (index < 0)
-        {
-            throw new ArgumentOutOfRangeException(nameof(index));
-        }
+        ArgumentOutOfRangeException.ThrowIfNegative(index);
 
         Parent = parent ?? throw new ArgumentNullException(nameof(parent));
         ParentIndex = index;

src/HotChocolate/Core/src/Features/FeatureCollection.cs

@@ -35,10 +35,7 @@ public FeatureCollection()
     /// </exception>
     public FeatureCollection(int initialCapacity)
     {
-        if (initialCapacity < 0)
-        {
-            throw new ArgumentOutOfRangeException(nameof(initialCapacity));
-        }
+        ArgumentOutOfRangeException.ThrowIfNegative(initialCapacity);
 
         _initialCapacity = initialCapacity;
     }

src/HotChocolate/Core/src/Validation/DocumentValidatorContext.cs

@@ -146,13 +146,7 @@ public void Initialize(
     {
         ArgumentNullException.ThrowIfNull(schema);
         ArgumentNullException.ThrowIfNull(document);
-
-        if (maxAllowedErrors < 1)
-        {
-            throw new ArgumentOutOfRangeException(
-                nameof(maxAllowedErrors),
-                "The maximum allowed errors must be greater than 0.");
-        }
+        ArgumentOutOfRangeException.ThrowIfLessThan(maxAllowedErrors, 1);
 
         _schema = schema;
         DocumentId = documentId;

src/HotChocolate/Fusion-vnext/src/Fusion.Language/Properties/FusionLanguageResources.Designer.cs

@@ -30,9 +30,6 @@
   <data name="MaxAllowedTokensExceeded" xml:space="preserve">
     <value>Source text contains more than {0} tokens. Parsing aborted.</value>
   </data>
-  <data name="NewLineMustBeGreaterThanOrEqualToOne" xml:space="preserve">
-    <value>Must be greater than or equal to 1.</value>
-  </data>
   <data name="SourceTextCannotBeEmpty" xml:space="preserve">
     <value>The source text cannot be empty.</value>
   </data>

src/HotChocolate/Fusion-vnext/src/Fusion.Language/Properties/FusionLanguageResources.resx

@@ -237,13 +237,7 @@ private void NewLine()
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     private void NewLine(int lines)
     {
-        if (lines < 1)
-        {
-            throw new ArgumentOutOfRangeException(
-                nameof(lines),
-                lines,
-                NewLineMustBeGreaterThanOrEqualToOne);
-        }
+        ArgumentOutOfRangeException.ThrowIfLessThan(lines, 1);
 
         Line += lines;
         LineStart = Position;

src/HotChocolate/Fusion-vnext/src/Fusion.Language/Readers/FieldSelectionMapReader.cs

@@ -78,10 +78,7 @@ public void Advance(int count)
             throw new ObjectDisposedException(nameof(PooledArrayWriter));
         }
 
-        if (count < 0)
-        {
-            throw new ArgumentOutOfRangeException(nameof(count));
-        }
+        ArgumentOutOfRangeException.ThrowIfNegative(count);
 
         if (count > _capacity)
         {
@@ -114,10 +111,7 @@ public Memory<byte> GetMemory(int sizeHint = 0)
             throw new ObjectDisposedException(nameof(PooledArrayWriter));
         }
 
-        if (sizeHint < 0)
-        {
-            throw new ArgumentOutOfRangeException(nameof(sizeHint));
-        }
+        ArgumentOutOfRangeException.ThrowIfNegative(sizeHint);
 
         var size = sizeHint < 1
             ? _initialBufferSize
@@ -145,10 +139,7 @@ public Span<byte> GetSpan(int sizeHint = 0)
             throw new ObjectDisposedException(nameof(PooledArrayWriter));
         }
 
-        if (sizeHint < 0)
-        {
-            throw new ArgumentOutOfRangeException(nameof(sizeHint));
-        }
+        ArgumentOutOfRangeException.ThrowIfNegative(sizeHint);
 
         var size = sizeHint < 1 ? _initialBufferSize : sizeHint;
         EnsureBufferCapacity(size);

src/HotChocolate/Utilities/src/Utilities.Buffers/PooledArrayWriter.cs

@@ -76,10 +76,7 @@ public void Advance(int count)
             throw new ObjectDisposedException(nameof(ArrayWriter));
         }
 
-        if (count < 0)
-        {
-            throw new ArgumentOutOfRangeException(nameof(count));
-        }
+        ArgumentOutOfRangeException.ThrowIfNegative(count);
 
         if (count > _capacity)
         {
@@ -112,10 +109,7 @@ public Memory<byte> GetMemory(int sizeHint = 0)
             throw new ObjectDisposedException(nameof(ArrayWriter));
         }
 
-        if (sizeHint < 0)
-        {
-            throw new ArgumentOutOfRangeException(nameof(sizeHint));
-        }
+        ArgumentOutOfRangeException.ThrowIfNegative(sizeHint);
 
         var size = sizeHint < 1
             ? _initialBufferSize
@@ -143,10 +137,7 @@ public Span<byte> GetSpan(int sizeHint = 0)
             throw new ObjectDisposedException(nameof(ArrayWriter));
         }
 
-        if (sizeHint < 0)
-        {
-            throw new ArgumentOutOfRangeException(nameof(sizeHint));
-        }
+        ArgumentOutOfRangeException.ThrowIfNegative(sizeHint);
 
         var size = sizeHint < 1
             ? _initialBufferSize