Updated code to use the ArgumentException throw helper (#8320)

Author: glen-84

.editorconfig

@@ -152,6 +152,9 @@ dotnet_naming_style.static_prefix_style.capitalization = camel_case
 
 # Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance.
 dotnet_diagnostic.CA1510.severity = warning
+# Use 'ArgumentException.ThrowIfNullOrEmpty' instead of explicitly throwing a new exception instance.
+dotnet_diagnostic.CA1511.severity = warning
 
 [src/HotChocolate/Language/**/*.cs]
 dotnet_diagnostic.CA1510.severity = none
+dotnet_diagnostic.CA1511.severity = none

src/CookieCrumble/src/CookieCrumble/Snapshot.cs

@@ -183,21 +183,15 @@ public Snapshot Add(SnapshotValue value)
 
     public Snapshot SetExtension(string extension)
     {
-        if (string.IsNullOrEmpty(extension))
-        {
-            throw new ArgumentNullException(nameof(extension));
-        }
+        ArgumentException.ThrowIfNullOrEmpty(extension);
 
         _extension = extension;
         return this;
     }
 
     public Snapshot SetPostFix(string postFix)
     {
-        if (string.IsNullOrEmpty(postFix))
-        {
-            throw new ArgumentNullException(nameof(postFix));
-        }
+        ArgumentException.ThrowIfNullOrEmpty(postFix);
 
         _postFix = postFix;
         return this;

src/GreenDonut/src/GreenDonut/DataLoaderBase.cs

@@ -278,11 +278,7 @@ public IDataLoader Branch<TState>(
         CreateDataLoaderBranch<TKey, TValue, TState> createBranch,
         TState state)
     {
-        if (string.IsNullOrEmpty(key))
-        {
-            throw new ArgumentException("Value cannot be null or empty.", nameof(key));
-        }
-
+        ArgumentException.ThrowIfNullOrEmpty(key);
         ArgumentNullException.ThrowIfNull(createBranch);
 
         if (!AllowBranching)

src/GreenDonut/src/GreenDonut/Extensions/DataLoaderExtensions.cs

@@ -295,13 +295,7 @@ public static IDataLoader<TKey, TValue> SetState<TKey, TValue, TState>(
         where TKey : notnull
     {
         ArgumentNullException.ThrowIfNull(dataLoader);
-
-        if (string.IsNullOrEmpty(key))
-        {
-            throw new ArgumentException(
-                "The key must not be null or empty.",
-                nameof(key));
-        }
+        ArgumentException.ThrowIfNullOrEmpty(key);
 
         dataLoader.ContextData = dataLoader.ContextData.SetItem(key, value);
         return dataLoader;
@@ -378,13 +372,7 @@ public static IDataLoader<TKey, TValue> TrySetState<TKey, TValue, TState>(
         where TKey : notnull
     {
         ArgumentNullException.ThrowIfNull(dataLoader);
-
-        if (string.IsNullOrEmpty(key))
-        {
-            throw new ArgumentException(
-                "The key must not be null or empty.",
-                nameof(key));
-        }
+        ArgumentException.ThrowIfNullOrEmpty(key);
 
         if (!dataLoader.ContextData.ContainsKey(key))
         {
@@ -475,13 +463,7 @@ public static TState GetOrSetState<TKey, TValue, TState>(
         where TKey : notnull
     {
         ArgumentNullException.ThrowIfNull(dataLoader);
-
-        if (string.IsNullOrEmpty(key))
-        {
-            throw new ArgumentException(
-                "The key must not be null or empty.",
-                nameof(key));
-        }
+        ArgumentException.ThrowIfNullOrEmpty(key);
 
         if(!dataLoader.ContextData.TryGetValue(key, out var internalValue))
         {
@@ -563,13 +545,7 @@ public static IDataLoader<TKey, TValue> AddStateEnumerable<TKey, TValue, TState>
         where TKey : notnull
     {
         ArgumentNullException.ThrowIfNull(dataLoader);
-
-        if (string.IsNullOrEmpty(key))
-        {
-            throw new ArgumentException(
-                "The key must not be null or empty.",
-                nameof(key));
-        }
+        ArgumentException.ThrowIfNullOrEmpty(key);
 
         if (dataLoader.ContextData.TryGetValue(key, out var internalValue)
             && internalValue is ImmutableArray<TState> values)