Ordered named arguments according to the order of parameters (#8423)

glen-84 · web-flow · commit cf0d38a236c1 · 2025-07-03T17:52:55.000+02:00
diff --git a/.editorconfig b/.editorconfig
@@ -252,6 +252,8 @@ dotnet_diagnostic.RCS1118.severity = warning
 dotnet_diagnostic.RCS1160.severity = warning
 # Use constant instead of field.
 dotnet_diagnostic.RCS1187.severity = warning
+# Order named arguments according to the order of parameters.
+dotnet_diagnostic.RCS1205.severity = warning
 # Convert interpolated string to concatenation.
 dotnet_diagnostic.RCS1217.severity = warning
 # Unnecessary null-forgiving operator.
diff --git a/src/HotChocolate/AspNetCore/test/AspNetCore.Tests/IntrospectionTests.cs b/src/HotChocolate/AspNetCore/test/AspNetCore.Tests/IntrospectionTests.cs
@@ -222,15 +222,15 @@ public async Task Introspection_OfType_Depth_2_OK()
     private GraphQLHttpClient GetClient(string environment, bool removeRule = false)
     {
         var server = CreateStarWarsServer(
-            environment: environment,
             configureServices: s =>
             {
                 if (removeRule)
                 {
                     s.AddGraphQL()
                         .DisableIntrospection(disable: false);
                 }
-            });
+            },
+            environment: environment);
         return new DefaultGraphQLHttpClient(server.CreateClient());
     }
 }
diff --git a/src/HotChocolate/AspNetCore/test/Transport.Http.Tests/GraphQLHttpClientTests.cs b/src/HotChocolate/AspNetCore/test/Transport.Http.Tests/GraphQLHttpClientTests.cs
@@ -347,11 +347,11 @@ query B($episode: Episode!) {
               }
             }
             """,
+            operationName: "B",
             variables: new Dictionary<string, object?>
             {
                 ["episode"] = "JEDI"
-            },
-            operationName: "B");
+            });
 
         var requestUri = new Uri(CreateUrl("/graphql"));
 
@@ -587,11 +587,11 @@ query B($episode: Episode!) {
               }
             }
             """,
+            operationName: "B",
             variables: new Dictionary<string, object?>
             {
                 ["episode"] = "JEDI"
-            },
-            operationName: "B");
+            });
 
         var requestUri = new Uri(CreateUrl("/graphql"));
 
diff --git a/src/HotChocolate/Caching/test/Caching.Tests/HttpCachingTests.cs b/src/HotChocolate/Caching/test/Caching.Tests/HttpCachingTests.cs
@@ -356,7 +356,7 @@ public async Task SharedMaxAgeAndScope_Should_Cache()
                     d.Name("Query")
                         .Field("field")
                         .Resolve("")
-                        .CacheControl(sharedMaxAge: 2000, scope: CacheControlScope.Public));
+                        .CacheControl(scope: CacheControlScope.Public, sharedMaxAge: 2000));
         });
 
         var client = server.CreateClient();
diff --git a/src/HotChocolate/Core/src/Authorization/AuthorizeAttribute.cs b/src/HotChocolate/Core/src/Authorization/AuthorizeAttribute.cs
@@ -87,6 +87,6 @@ protected internal override void TryConfigure(
 
     private AuthorizeDirective CreateDirective()
     {
-        return new AuthorizeDirective(apply: Apply, policy: Policy, roles: Roles);
+        return new AuthorizeDirective(Policy, Roles, Apply);
     }
 }
diff --git a/src/HotChocolate/Core/src/Execution/Processing/OperationCompiler.cs b/src/HotChocolate/Core/src/Execution/Processing/OperationCompiler.cs
@@ -446,11 +446,11 @@ selection.SelectionSet is not null
                                 selection.SelectionSet.Selections))
                         : selection,
                     responseName: responseName,
-                    isParallelExecutable: field.IsParallelExecutable,
                     arguments: CoerceArgumentValues(field, selection, responseName),
                     includeConditions: includeCondition == 0
                         ? null
-                        : [includeCondition]);
+                        : [includeCondition],
+                    isParallelExecutable: field.IsParallelExecutable);
 
                 context.Fields.Add(responseName, preparedSelection);
 
diff --git a/src/HotChocolate/Core/src/Execution/Processing/Result/ResultBuilder.cs b/src/HotChocolate/Core/src/Execution/Processing/Result/ResultBuilder.cs
@@ -259,8 +259,8 @@ public IOperationResult BuildResult()
             _errors.Count == 0 ? null : _errors.ToArray(),
             CreateExtensionData(_extensions),
             CreateExtensionData(_contextData),
-            incremental: null,
             items: _items,
+            incremental: null,
             label: _label,
             path: _path,
             hasNext: _hasNext,
diff --git a/src/HotChocolate/Core/src/Subscriptions.RabbitMQ/RabbitMQTopic.cs b/src/HotChocolate/Core/src/Subscriptions.RabbitMQ/RabbitMQTopic.cs
@@ -78,8 +78,8 @@ private AsyncEventingBasicConsumer CreateConsumer(IModel channel, string queueNa
             exclusive: true,
             autoDelete: false);
         channel.QueueBind(
-            exchange: Name,
             queue: queueName,
+            exchange: Name,
             routingKey: string.Empty);
 
         return new AsyncEventingBasicConsumer(channel);
diff --git a/src/HotChocolate/Core/src/Types.Mutations/MutationConventionTypeInterceptor.cs b/src/HotChocolate/Core/src/Types.Mutations/MutationConventionTypeInterceptor.cs
@@ -261,8 +261,8 @@ private void TryApplyInputConvention(
                 Create<MutationConventionMiddleware>(
                     (typeof(string), options.InputArgumentName),
                     (typeof(IReadOnlyList<ResolverArgument>), resolverArguments)),
-                key: MutationArguments,
-                isRepeatable: false);
+                isRepeatable: false,
+                key: MutationArguments);
 
         mutation.Arguments.Clear();
         mutation.Arguments.Add(new(options.InputArgumentName, type: Parse($"{inputTypeName}!")));
@@ -353,8 +353,8 @@ private void TryApplyPayloadConvention(
             var nullMiddleware = _errorNullMiddleware ??=
                 new FieldMiddlewareConfiguration(
                     Create<ErrorNullMiddleware>(),
-                    key: MutationErrorNull,
-                    isRepeatable: false);
+                    isRepeatable: false,
+                    key: MutationErrorNull);
 
             foreach (var resultField in payloadTypeDef.Fields)
             {
@@ -410,8 +410,8 @@ private void TryApplyPayloadConvention(
                 new FieldMiddlewareConfiguration(
                     Create<ErrorMiddleware>(
                         (typeof(IReadOnlyList<CreateError>), errorFactories)),
-                    key: MutationErrors,
-                    isRepeatable: false);
+                    isRepeatable: false,
+                    key: MutationErrors);
 
             // last but not least we insert the error middleware to the mutation field.
             mutation.MiddlewareConfigurations.Insert(0, errorMiddleware);
@@ -440,8 +440,8 @@ private void TryApplyPayloadConvention(
                 new FieldMiddlewareConfiguration(
                     Create<ErrorMiddleware>(
                         (typeof(IReadOnlyList<CreateError>), errorFactories)),
-                    key: MutationErrors,
-                    isRepeatable: false);
+                    isRepeatable: false,
+                    key: MutationErrors);
 
             mutation.MiddlewareConfigurations.Insert(0, errorMiddleware);
         }
diff --git a/src/HotChocolate/Core/src/Types.Queries/QueryConventionTypeInterceptor.cs b/src/HotChocolate/Core/src/Types.Queries/QueryConventionTypeInterceptor.cs
@@ -147,8 +147,8 @@ public override void OnBeforeCompleteTypes()
                         new FieldMiddlewareConfiguration(
                             FieldClassMiddlewareFactory.Create<QueryResultMiddleware>(
                                 (typeof(IReadOnlyList<CreateError>), errorFactories)),
-                            key: "Query Results",
-                            isRepeatable: false);
+                            isRepeatable: false,
+                            key: "Query Results");
 
                     // last but not least we insert the result middleware to the query field.
                     field.MiddlewareConfigurations.Insert(0, errorMiddleware);
diff --git a/src/HotChocolate/Core/src/Types/Internal/ExtendedType.Members.cs b/src/HotChocolate/Core/src/Types/Internal/ExtendedType.Members.cs
@@ -173,8 +173,8 @@ private static ExtendedType CreateExtendedType(
                     type,
                     ExtendedTypeKind.Extended,
                     typeArguments: new[] { elementType },
-                    elementType: elementType,
                     source: type,
+                    elementType: elementType,
                     isNullable: state ?? false);
             }
 
diff --git a/src/HotChocolate/Core/src/Types/Internal/ExtendedType.SchemaType.cs b/src/HotChocolate/Core/src/Types/Internal/ExtendedType.SchemaType.cs
@@ -43,9 +43,9 @@ private static ExtendedType FromType(
                                 typeArguments: new[] { elementType },
                                 source: source,
                                 definition: typeof(ListType<>),
-                                isNullable: nullable,
+                                elementType: elementType,
                                 isList: true,
-                                elementType: elementType);
+                                isNullable: nullable);
                         });
                 }
             }
@@ -64,8 +64,8 @@ private static ExtendedType FromType(
                         typeArguments: SystemType.GetGenericArguments(type, cache),
                         source: source,
                         definition: definition,
-                        isNullable: nullable,
-                        isNamedType: true);
+                        isNamedType: true,
+                        isNullable: nullable);
                 });
         }
     }
diff --git a/src/HotChocolate/Core/src/Types/Internal/ExtendedType.SystemType.cs b/src/HotChocolate/Core/src/Types/Internal/ExtendedType.SystemType.cs
@@ -40,9 +40,9 @@ private static ExtendedType FromTypeInternal(Type type, TypeCache cache)
                 ExtendedTypeKind.Runtime,
                 typeArguments: typeArguments,
                 source: type,
-                isNullable: !type.IsValueType,
+                elementType: elementType,
                 isList: Helper.IsListType(type),
-                elementType: elementType);
+                isNullable: !type.IsValueType);
         }
 
         public static IReadOnlyList<ExtendedType> GetGenericArguments(
diff --git a/src/HotChocolate/Core/src/Types/SemanticNonNullTypeInterceptor.cs b/src/HotChocolate/Core/src/Types/SemanticNonNullTypeInterceptor.cs
@@ -308,8 +308,8 @@ private static ResultFormatterConfiguration CreateSemanticNonNullResultFormatter
 
                 return result;
             },
-            key: WellKnownMiddleware.SemanticNonNull,
-            isRepeatable: false);
+            isRepeatable: false,
+            key: WellKnownMiddleware.SemanticNonNull);
 
     private static void CheckResultForSemanticNonNullViolations(object? result, IResolverContext context, Path path,
         HashSet<int> levels,
diff --git a/src/HotChocolate/Core/src/Types/Types/Relay/Descriptors/NodeDescriptorBase.cs b/src/HotChocolate/Core/src/Types/Types/Relay/Descriptors/NodeDescriptorBase.cs
@@ -187,7 +187,7 @@ public static ResultFormatterConfiguration Create(
                     => result is not null
                         ? serializerAccessor.Serializer.Format(context.ObjectType.Name, result)
                         : null,
-                key: WellKnownMiddleware.GlobalId,
-                isRepeatable: false);
+                isRepeatable: false,
+                key: WellKnownMiddleware.GlobalId);
     }
 }
diff --git a/src/HotChocolate/Core/test/Execution.Tests/Configuration/TypeModuleTests.cs b/src/HotChocolate/Core/test/Execution.Tests/Configuration/TypeModuleTests.cs
@@ -78,12 +78,14 @@ public async Task Ensure_Warmups_Are_Triggered_An_Appropriate_Number_Of_Times()
         services
             .AddGraphQL()
             .AddTypeModule(_ => typeModule)
-            .InitializeOnStartup(keepWarm: true, warmup: (_, _) =>
-            {
-                warmups++;
-                warmupResetEvent.Set();
-                return Task.CompletedTask;
-            })
+            .InitializeOnStartup(
+                warmup: (_, _) =>
+                {
+                    warmups++;
+                    warmupResetEvent.Set();
+                    return Task.CompletedTask;
+                },
+                keepWarm: true)
             .AddQueryType(d => d.Field("foo").Resolve(""));
         var provider = services.BuildServiceProvider();
         var warmupService = provider.GetRequiredService<IHostedService>();
diff --git a/src/HotChocolate/Core/test/Execution.Tests/Integration/StarWarsCodeFirst/StarWarsCodeFirstTests.cs b/src/HotChocolate/Core/test/Execution.Tests/Integration/StarWarsCodeFirst/StarWarsCodeFirstTests.cs
@@ -908,12 +908,12 @@ ... on Droid {
                     }
                 }
             }",
-            request: r => { r.SetMaximumAllowedExecutionDepth(100); },
             configure: c =>
             {
                 AddDefaultConfiguration(c);
                 c.AddMaxExecutionDepthRule(3, allowRequestOverrides: true);
-            });
+            },
+            request: r => { r.SetMaximumAllowedExecutionDepth(100); });
     }
 
     [Fact]
@@ -958,12 +958,12 @@ ... on Droid {
                     }
                 }
             }",
-            request: r => { r.SkipExecutionDepthAnalysis(); },
             configure: c =>
             {
                 AddDefaultConfiguration(c);
                 c.AddMaxExecutionDepthRule(3, allowRequestOverrides: true);
-            });
+            },
+            request: r => { r.SkipExecutionDepthAnalysis(); });
     }
 
     // this test ensures that overridden depth validations are not cached.
diff --git a/src/HotChocolate/Core/test/Execution.Tests/Integration/TypeConverter/TypeConverterTests.cs b/src/HotChocolate/Core/test/Execution.Tests/Integration/TypeConverter/TypeConverterTests.cs
@@ -21,6 +21,7 @@ query foo($a: FooInput!) {
                         number
                     }
                 }",
+                configure: c => c.AddQueryType<Query>(),
                 request: r => r.SetVariableValues(
                     new Dictionary<string, object?>
                     {
@@ -33,8 +34,7 @@ query foo($a: FooInput!) {
                                 { "number", (byte)123 }
                             }
                         }
-                    }),
-                configure: c => c.AddQueryType<Query>())
+                    }))
             .MatchSnapshotAsync();
     }
 
@@ -46,9 +46,9 @@ await ExpectValid(
                 query foo($time: DateTime) {
                     time(time: $time)
                 }",
+                configure: c => c.AddQueryType<QueryType>(),
                 request: r => r.SetVariableValues(
-                    new Dictionary<string, object?> { { "time", "2018-05-29T01:00:00Z" } }),
-                configure: c => c.AddQueryType<QueryType>())
+                    new Dictionary<string, object?> { { "time", "2018-05-29T01:00:00Z" } }))
             .MatchSnapshotAsync();
     }
 
@@ -61,8 +61,8 @@ await ExpectValid(
                 query foo($time: DateTime) {
                     time(time: $time)
                 }",
-                request: r => r.SetVariableValues(new Dictionary<string, object?> { { "time", time } }),
-                configure: c => c.AddQueryType<QueryType>())
+                configure: c => c.AddQueryType<QueryType>(),
+                request: r => r.SetVariableValues(new Dictionary<string, object?> { { "time", time } }))
             .MatchSnapshotAsync();
     }
 
@@ -78,6 +78,7 @@ query foo($a: FooInput!) {
                         number
                     }
                 }",
+                configure: c => c.AddQueryType<QueryType>(),
                 request: r => r.SetVariableValues(
                     new Dictionary<string, object?>
                     {
@@ -90,8 +91,7 @@ query foo($a: FooInput!) {
                                 { "number", (byte)123 }
                             }
                         }
-                    }),
-                configure: c => c.AddQueryType<QueryType>())
+                    }))
             .MatchSnapshotAsync();
     }
 
diff --git a/src/HotChocolate/Core/test/Execution.Tests/Processing/OperationCompilerTests.cs b/src/HotChocolate/Core/test/Execution.Tests/Processing/OperationCompilerTests.cs
@@ -1443,8 +1443,8 @@ public void OptimizeSelectionSet(SelectionSetOptimizerContext context)
                     baz.Type,
                     bazSelection,
                     "someName",
-                    resolverPipeline: bazPipeline,
-                    isInternal: true);
+                    isInternal: true,
+                    resolverPipeline: bazPipeline);
 
                 context.AddSelection(compiledSelection);
             }
diff --git a/src/HotChocolate/Core/test/Execution.Tests/RequestExecutorResolverTests.cs b/src/HotChocolate/Core/test/Execution.Tests/RequestExecutorResolverTests.cs
@@ -54,13 +54,13 @@ public async Task Executor_Should_Only_Be_Switched_Once_It_Is_Warmed_Up()
         var manager = new ServiceCollection()
             .AddGraphQL()
             .InitializeOnStartup(
-                keepWarm: true,
                 warmup: (_, _) =>
                 {
                     warmupResetEvent.Wait(cts.Token);
 
                     return Task.CompletedTask;
-                })
+                },
+                keepWarm: true)
             .AddQueryType(d => d.Field("foo").Resolve(""))
             .Services.BuildServiceProvider()
             .GetRequiredService<RequestExecutorManager>();
@@ -107,12 +107,12 @@ public async Task WarmupSchemaTasks_Are_Applied_Correct_Number_Of_Times(
         var manager = new ServiceCollection()
             .AddGraphQL()
             .InitializeOnStartup(
-                keepWarm: keepWarm,
                 warmup: (_, _) =>
                 {
                     warmups++;
                     return Task.CompletedTask;
-                })
+                },
+                keepWarm: keepWarm)
             .AddQueryType(d => d.Field("foo").Resolve(""))
             .Services.BuildServiceProvider()
             .GetRequiredService<RequestExecutorManager>();
diff --git a/src/HotChocolate/Core/test/Types.CursorPagination.Tests/QueryableCursorPagingProviderTests.cs b/src/HotChocolate/Core/test/Types.CursorPagination.Tests/QueryableCursorPagingProviderTests.cs
diff --git a/src/HotChocolate/Data/src/Data/Projections/Expressions/Optimizers/QueryablePagingProjectionOptimizer.cs b/src/HotChocolate/Data/src/Data/Projections/Expressions/Optimizers/QueryablePagingProjectionOptimizer.cs
diff --git a/src/HotChocolate/Data/src/Data/Projections/Optimizers/IsProjectedProjectionOptimizer.cs b/src/HotChocolate/Data/src/Data/Projections/Optimizers/IsProjectedProjectionOptimizer.cs
diff --git a/src/HotChocolate/Data/test/Data.Projections.SqlServer.Tests/QueryableProjectionInterfaceTypeTests.cs b/src/HotChocolate/Data/test/Data.Projections.SqlServer.Tests/QueryableProjectionInterfaceTypeTests.cs
diff --git a/src/HotChocolate/MongoDb/test/Data.MongoDb.Projections.Tests/SchemaCache.cs b/src/HotChocolate/MongoDb/test/Data.MongoDb.Projections.Tests/SchemaCache.cs
diff --git a/src/HotChocolate/Raven/test/Data.Raven.Projections.Tests/QueryableProjectionInterfaceTypeTests.cs b/src/HotChocolate/Raven/test/Data.Raven.Projections.Tests/QueryableProjectionInterfaceTypeTests.cs

Original file line number	Diff line number	Diff line change
`@@ -222,15 +222,15 @@ public async Task Introspection_OfType_Depth_2_OK()`
`222`	`222`	`private GraphQLHttpClient GetClient(string environment, bool removeRule = false)`
`223`	`223`	`{`
`224`	`224`	`var server = CreateStarWarsServer(`
`225`		`- environment: environment,`
`226`	`225`	`configureServices: s =>`
`227`	`226`	`{`
`228`	`227`	`if (removeRule)`
`229`	`228`	`{`
`230`	`229`	`s.AddGraphQL()`
`231`	`230`	`.DisableIntrospection(disable: false);`
`232`	`231`	`}`
`233`		`- });`
	`232`	`+ },`
	`233`	`+ environment: environment);`
`234`	`234`	`return new DefaultGraphQLHttpClient(server.CreateClient());`
`235`	`235`	`}`
`236`	`236`	`}`
Original file line number	Diff line number	Diff line change
`@@ -347,11 +347,11 @@ query B($episode: Episode!) {`
`347`	`347`	`}`
`348`	`348`	`}`
`349`	`349`	`""",`
	`350`	`+ operationName: "B",`
`350`	`351`	`variables: new Dictionary<string, object?>`
`351`	`352`	`{`
`352`	`353`	`["episode"] = "JEDI"`
`353`		`- },`
`354`		`- operationName: "B");`
	`354`	`+ });`
`355`	`355`
`356`	`356`	`var requestUri = new Uri(CreateUrl("/graphql"));`
`357`	`357`
`@@ -587,11 +587,11 @@ query B($episode: Episode!) {`
`587`	`587`	`}`
`588`	`588`	`}`
`589`	`589`	`""",`
	`590`	`+ operationName: "B",`
`590`	`591`	`variables: new Dictionary<string, object?>`
`591`	`592`	`{`
`592`	`593`	`["episode"] = "JEDI"`
`593`		`- },`
`594`		`- operationName: "B");`
	`594`	`+ });`
`595`	`595`
`596`	`596`	`var requestUri = new Uri(CreateUrl("/graphql"));`
`597`	`597`
Original file line number	Diff line number	Diff line change
`@@ -87,6 +87,6 @@ protected internal override void TryConfigure(`
`87`	`87`
`88`	`88`	`private AuthorizeDirective CreateDirective()`
`89`	`89`	`{`
`90`		`- return new AuthorizeDirective(apply: Apply, policy: Policy, roles: Roles);`
	`90`	`+ return new AuthorizeDirective(Policy, Roles, Apply);`
`91`	`91`	`}`
`92`	`92`	`}`