Skip to content

Conversation

@michaelstaib
Copy link
Member

@michaelstaib michaelstaib commented Apr 7, 2025

No description provided.

@michaelstaib michaelstaib force-pushed the mst/field-merging-v2 branch from ba7de71 to 87219a4 Compare April 7, 2025 12:48
@michaelstaib michaelstaib added this to the HC-15.1.4 milestone Apr 11, 2025
@michaelstaib michaelstaib modified the milestones: HC-15.1.4, HC-16.0.0 May 15, 2025
@michaelstaib michaelstaib marked this pull request as draft August 28, 2025 07:25
@tobias-tengler tobias-tengler marked this pull request as ready for review January 19, 2026 09:49
Copilot AI review requested due to automatic review settings January 19, 2026 09:49
@tobias-tengler tobias-tengler changed the title Aligned to GraphQL Java Field Merging Rule [Validation] Aligned to GraphQL Java Field Merging Rule Jan 19, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates test snapshots to align with the GraphQL Java field merging rule implementation. The changes primarily involve updating error message formats and GraphQL specification references.

Changes:

  • Updated error message JSON structure format (removed wrapper arrays, changed property casing)
  • Updated GraphQL specification URLs from October 2021 to September 2025
  • Modified error message formats to improve clarity and consistency

Reviewed changes

Copilot reviewed 298 out of 450 changed files in this pull request and generated no comments.

Show a summary per file
File Description
LoneAnonymousOperationRuleTests snapshots Updated JSON format and spec URLs for anonymous operation validation errors
LeafFieldSelectionsRuleTests snapshots Updated error messages for leaf field selection validation with new format and spec references
KnownFragmentNamesTests snapshots Updated fragment validation error format with separator delimiters
InputObjectRequiredFieldsRuleTests snapshots Updated required field validation error format
InputObjectFieldUniquenessRuleTests snapshots Updated field uniqueness error format with separator delimiters
InputObjectFieldNamesRuleTests snapshots Updated field name validation error format
FragmentsOnCompositeTypesRuleTests snapshots Updated composite type fragment validation error format
FragmentsMustBeUsedRuleTests snapshots Updated unused fragment error format
FragmentSpread* test snapshots Updated fragment spread validation error formats
FragmentNameUniquenessRuleTests snapshots Updated fragment name uniqueness error format with separators
FieldsOnCorrectTypeRuleTests snapshots Updated field type validation error format
FieldSelectionMergingRuleTests snapshots Updated field merging conflict error messages with improved clarity
DocumentValidatorTests snapshots Updated various validation error formats across multiple test scenarios
Files not reviewed (1)
  • src/HotChocolate/Core/src/Validation/Properties/Resources.Designer.cs: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

🚀 Fusion Gateway Performance Results

Simple Composite Query

Constant Load (50 VUs)

Requests/sec Error Rate
5880.29 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.82ms 7.08ms 162.17ms 8.35ms 12.97ms 18.66ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
4576.31 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.84ms 37.69ms 239.36ms 48.47ms 110.37ms 129.65ms

Executed Query

fragment User on User {
  id
  username
  name
}

fragment Review on Review {
  id
  body
}

fragment Product on Product {
  inStock
  name
  price
  shippingEstimate
  upc
  weight
}

query TestQuery {
  topProducts(first: 5) {
    ...Product
    reviews {
      ...Review
      author {
        ...User
      }
    }
  }
}

Deep Recursion Query

Constant Load (50 VUs)

Requests/sec Error Rate
266.72 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
13.22ms 176.09ms 568.52ms 181.70ms 227.66ms 254.87ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
306.97 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
2.98ms 689.56ms 1649.06ms 690.07ms 1363.24ms 1458.87ms

Executed Query

fragment User on User {
  id
  username
  name
}

fragment Review on Review {
  id
  body
}

fragment Product on Product {
  inStock
  name
  price
  shippingEstimate
  upc
  weight
}

query TestQuery {
  users {
    ...User
    reviews {
      ...Review
      product {
        ...Product
        reviews {
          ...Review
          author {
            ...User
            reviews {
              ...Review
              product {
                ...Product
              }
            }
          }
        }
      }
    }
  }
  topProducts(first: 5) {
    ...Product
    reviews {
      ...Review
      author {
        ...User
        reviews {
          ...Review
          product {
            ...Product
          }
        }
      }
    }
  }
}

Variable Batching Throughput

Constant Load (50 VUs)

Requests/sec Error Rate
23965.44 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.09ms 1.68ms 46.15ms 2.04ms 3.86ms 4.73ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
18837.78 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.09ms 9.23ms 104.95ms 11.19ms 23.15ms 27.98ms

Executed Query

query TestQuery_8f7a46ce_2(
  $__fusion_1_upc: ID!
  $__fusion_2_price: Long!
  $__fusion_2_weight: Long!
) {
  productByUpc(upc: $__fusion_1_upc) {
    inStock
    shippingEstimate(weight: $__fusion_2_weight, price: $__fusion_2_price)
  }
}

Variables (5 sets batched in single request)

[
  { "__fusion_1_upc": "1", "__fusion_2_price": 899, "__fusion_2_weight": 100 },
  { "__fusion_1_upc": "2", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 },
  { "__fusion_1_upc": "3", "__fusion_2_price": 15, "__fusion_2_weight": 20 },
  { "__fusion_1_upc": "4", "__fusion_2_price": 499, "__fusion_2_weight": 100 },
  { "__fusion_1_upc": "5", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 }
]

No baseline data available for comparison.


Run 21132846931 • Commit 33dd48d • Mon, 19 Jan 2026 10:09:50 GMT

@tobias-tengler tobias-tengler merged commit ca63d0a into main Jan 19, 2026
116 checks passed
@tobias-tengler tobias-tengler deleted the mst/field-merging-v2 branch January 19, 2026 10:32
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (6a3b7a3) to head (52e2f76).
⚠️ Report is 685 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #8231       +/-   ##
==========================================
- Coverage   74.16%       0   -74.17%     
==========================================
  Files        2677       0     -2677     
  Lines      140790       0   -140790     
  Branches    16371       0    -16371     
==========================================
- Hits       104421       0   -104421     
+ Misses      30774       0    -30774     
+ Partials     5595       0     -5595     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

🚀 Fusion Gateway Performance Results

Simple Composite Query

Constant Load (50 VUs)

Requests/sec Error Rate
5793.88 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.78ms 7.18ms 163.32ms 8.47ms 13.22ms 18.96ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
4565.93 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.75ms 38.95ms 272.00ms 48.66ms 108.64ms 124.98ms

Executed Query

fragment User on User {
  id
  username
  name
}

fragment Review on Review {
  id
  body
}

fragment Product on Product {
  inStock
  name
  price
  shippingEstimate
  upc
  weight
}

query TestQuery {
  topProducts(first: 5) {
    ...Product
    reviews {
      ...Review
      author {
        ...User
      }
    }
  }
}

Deep Recursion Query

Constant Load (50 VUs)

Requests/sec Error Rate
267.62 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
12.78ms 174.39ms 784.27ms 181.24ms 227.04ms 251.19ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
307.23 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
3.01ms 682.16ms 1717.70ms 688.58ms 1333.98ms 1480.70ms

Executed Query

fragment User on User {
  id
  username
  name
}

fragment Review on Review {
  id
  body
}

fragment Product on Product {
  inStock
  name
  price
  shippingEstimate
  upc
  weight
}

query TestQuery {
  users {
    ...User
    reviews {
      ...Review
      product {
        ...Product
        reviews {
          ...Review
          author {
            ...User
            reviews {
              ...Review
              product {
                ...Product
              }
            }
          }
        }
      }
    }
  }
  topProducts(first: 5) {
    ...Product
    reviews {
      ...Review
      author {
        ...User
        reviews {
          ...Review
          product {
            ...Product
          }
        }
      }
    }
  }
}

Variable Batching Throughput

Constant Load (50 VUs)

Requests/sec Error Rate
24063.45 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.09ms 1.68ms 38.65ms 2.03ms 3.87ms 4.72ms

Ramping Load (0→50→500→50 VUs)

Requests/sec Error Rate
18612.35 req/s 0.00%
📊 Response Time Metrics
Min Med Max Avg P90 P95
0.09ms 9.30ms 109.03ms 11.32ms 23.36ms 28.25ms

Executed Query

query TestQuery_8f7a46ce_2(
  $__fusion_1_upc: ID!
  $__fusion_2_price: Long!
  $__fusion_2_weight: Long!
) {
  productByUpc(upc: $__fusion_1_upc) {
    inStock
    shippingEstimate(weight: $__fusion_2_weight, price: $__fusion_2_price)
  }
}

Variables (5 sets batched in single request)

[
  { "__fusion_1_upc": "1", "__fusion_2_price": 899, "__fusion_2_weight": 100 },
  { "__fusion_1_upc": "2", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 },
  { "__fusion_1_upc": "3", "__fusion_2_price": 15, "__fusion_2_weight": 20 },
  { "__fusion_1_upc": "4", "__fusion_2_price": 499, "__fusion_2_weight": 100 },
  { "__fusion_1_upc": "5", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 }
]

No baseline data available for comparison.


Run 21133601361 • Commit f8ef856 • Mon, 19 Jan 2026 10:46:59 GMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants