[Fusion] Support abstract lookups #8485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-tengler
commented
Aug 2, 2025
src/HotChocolate/Fusion-vnext/test/Fusion.Execution.Tests/Planning/OperationPlannerTests.cs
Show resolved
Hide resolved
tobias-tengler
force-pushed
the
tte/fusion-abstract-type-lookup
branch
2 times, most recently
from
ff57b88 to
217fcee
Compare
tobias-tengler
force-pushed
the
tte/fusion-abstract-type-lookup
branch
from
217fcee to
b12afbf
Compare
michaelstaib
reviewed
Aug 4, 2025
...ocolate/Fusion-vnext/src/Fusion.Execution.Types/Collections/SourceInterfaceTypeCollection.cs
Outdated
Show resolved
Hide resolved
tobias-tengler
force-pushed
the
tte/fusion-abstract-type-lookup
branch
from
eda4341 to
f61eb35
Compare
tobias-tengler
commented
Aug 13, 2025
src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Planning/OperationPlanner.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on global object identification I've noticed that the planning currently doesn't consider abstract lookups. The composition already has support and also properly checks satisfiability.
This PR updates the planning phase to consider the lookups of implemented interfaces and unions the given object type is a member of.