Run swift linux tests in docker container#52
Merged
mattmassicotte merged 2 commits intoChimeHQ:mainfrom Mar 10, 2026
Merged
Conversation
ThisIsMissEm
commented
Mar 2, 2026
Comment on lines
+51
to
+53
| - "6.1" | ||
| - "6.2" | ||
| - "latest" |
Contributor
Author
There was a problem hiding this comment.
Quoting here is actually recommended, since someone unknowningly adding 6.0 or similar would end up with the tests running on swift 6 due to yaml's handling of float values.
3 tasks
Contributor
|
I was seeing a lot of instability too, but that's uncommon. I think it could have been on the Github side. However, that said, this approach is actually super interesting! I've not encountered it before and I like it. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was seeing too much instability in #50 with regards to the linux tests, due to the
vapor/swiftly-actionneeding to install dependencies on ubuntu, which was randomly failing.As a way to sidestep that issue, we can actually use the swift docker images to run these tests: https://hub.docker.com/_/swift/tags
This removes the need to install any ubuntu dependencies required to install swiftly, and gives a reproducible environment to run the tests in.