Feature: Pass generic additional parameters back through Login#55
Open
ThisIsMissEm wants to merge 5 commits intoChimeHQ:mainfrom
Open
Feature: Pass generic additional parameters back through Login#55ThisIsMissEm wants to merge 5 commits intoChimeHQ:mainfrom
ThisIsMissEm wants to merge 5 commits intoChimeHQ:mainfrom
Conversation
This also ensures we clearly signal to the DPoP request method whether we are talking to an authorization server or a resource server (since these give different OAuth Error responses). The test coverage has increased dramatically here.
This is actually generic OAuth token response logic, but the package is currently structured to make this bluesky specific.
This allows apps using the Bluesky client to retrieve the DID for the authenticated account from the Login.
Contributor
Author
|
(The relevant downstream PR: germ-network#2 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change came from @anna-germ, and allows consuming code to extract the DID from the
Loginobject, which we need to grab the PDS URL for the authenticated account.