Skip to content

Fixed instantiating direct pins in ChipflowTop #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025
Merged

Fixed instantiating direct pins in ChipflowTop #103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
684c285
Fixed instntiating direct pins in the ChipflowTop
lanserge May 8, 2025
13d1ae8
Updated check for interfaces created from PinSignature
lanserge May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions chipflow_lib/steps/silicon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from . import StepBase
from .. import ChipFlowError
from ..platforms import SiliconPlatform, top_interfaces, load_pinlock
from ..platforms.utils import PinSignature


logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -46,10 +47,10 @@ def elaborate(self, platform: SiliconPlatform):
for component, iface in platform.pinlock.port_map.items():
for iface_name, member, in iface.items():
for name, port in member.items():
platform.ports[port.port_name].wire(
m,
getattr(getattr(top[component], iface_name), name)
)
iface = getattr(top[component], iface_name)
wire = (iface if isinstance(iface.signature, PinSignature)
else getattr(iface, name))
platform.ports[port.port_name].wire(m, wire)
return m


Expand Down
Loading