Handle ReadTimeout error in submit #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gatecat
reviewed
Jun 25, 2025
Contributor
Author
|
That was duplicated, see above (unless I’ve made a mistake..)
…On Wed, 25 Jun 2025 at 12:00, myrtle ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In chipflow_lib/steps/silicon.py
<#123 (comment)>
:
> @@ -200,8 +200,8 @@ def network_err(e):
except requests.ConnectionError as e:
if type(e.__context__) is urllib3.exceptions.MaxRetryError:
network_err(e)
- except requests.ConnectTimeout as e:
should we not still handle connection timeouts as well? I can imagine them
being just as possible as read timeouts during transient network issues, etc
—
Reply to this email directly, view it on GitHub
<#123 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB4O4FOCL7JHITXQXGCJC33FJ6MTAVCNFSM6AAAAACAC53NKOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSNJXG4YDCMJTGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
Yes you're right, looking at the complete code I see that now. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.