Handle authentication error correctly #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
robtaylor
force-pushed
the
fix-assert-authentication
branch
from
9c9f728 to
a21aa6b
Compare
robtaylor
force-pushed
the
fix-assert-authentication
branch
from
a21aa6b to
d87d7e3
Compare
gatecat
reviewed
Sep 9, 2025
Contributor
Author
|
Yep, the elements that are being picked out can’t have white space in, at
least afaict.
…On Tue, 9 Sep 2025 at 08:30, myrtle ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In chipflow_lib/steps/silicon.py
<#139 (comment)>
:
> - if type(e.__context__) is urllib3.exceptions.ReadTimeoutError:
- continue #just timed out, continue long poll
+ logger.debug("Long poll start")
+ try:
+ log_resp = requests.get(
+ self._log_stream_url,
+ auth=("", self._chipflow_api_key),
+ stream=True,
+ timeout=(2.0, 60.0) # fail if connect takes >2s, long poll for 60s at a time
+ )
+ if log_resp.status_code == 200:
+ logger.debug(f"response from {self._log_stream_url}:\n{log_resp}")
+ for line in log_resp.iter_lines():
+ message = line.decode("utf-8") if line else ""
+ try:
+ level, time, step = message.split(maxsplit=2)
are you sure that calling split with no seperator specified (i.e. split on
all whitespace) is correct here?
—
Reply to this email directly, view it on GitHub
<#139 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB4O4AWOUYLGDGZLGOBZH33RZ63DAVCNFSM6AAAAACFLB5KACVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCOJZHAYDEOBZGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
gatecat
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes some logic and presentation issues in streaming