Use new build system #44
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
robtaylor
force-pushed
the
new-build-system
branch
from
e37f981 to
acf8f43
Compare
robtaylor
approved these changes
Mar 6, 2025
robtaylor
force-pushed
the
new-build-system
branch
from
acf8f43 to
0c4c701
Compare
robtaylor
requested changes
Mar 6, 2025
| os.environ.get("CHIPFLOW_API_ENDPOINT", "https://app.chipflow-infra.com/api/builds"), | ||
| auth=(os.environ["CHIPFLOW_API_KEY_ID"], os.environ["CHIPFLOW_API_KEY_SECRET"]), | ||
| os.environ.get("CHIPFLOW_API_ENDPOINT", "https://build.chipflow.org/api/builds"), | ||
| auth=os.environ["CHIPFLOW_API_KEY"], |
Contributor
There was a problem hiding this comment.
auth takes a tuple: ('user', 'pass')
robtaylor
requested changes
Mar 6, 2025
Comment on lines
-160
to
-180
| if resp.status_code == 403: | ||
| raise ChipFlowError( | ||
| "Authentication failed; please verify the values of the the CHIPFLOW_API_KEY_ID " | ||
| "and CHIPFLOW_API_KEY_SECRET environment variables, if the issue persists, " | ||
| "contact support to resolve it") | ||
| elif resp.status_code >= 400: | ||
| raise ChipFlowError( | ||
| f"Submission failed ({resp_data['statusCode']} {resp_data['error']}: " | ||
| f"{resp_data['message']}); please contact support and provide this error message") | ||
| elif resp.status_code >= 300: | ||
| assert False, "3xx responses should not be returned" | ||
| elif resp.status_code >= 200: | ||
| if not resp_data["ok"]: | ||
| raise ChipFlowError( | ||
| f"Submission failed ({resp_data['msg']}); please contact support and provide " | ||
| f"this error message") | ||
| else: | ||
| print(f"{resp_data['msg']} (#{resp_data['id']}: {resp_data['name']}); " | ||
| f"{resp_data['url']}") | ||
| else: | ||
| ChipFlowError(f"Unexpected response from API: {resp}") |
Contributor
There was a problem hiding this comment.
Error handling is still needed. Auth failure, or other issues on cloud side - I just got a 404 for example. no idea why!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.