-
Notifications
You must be signed in to change notification settings - Fork 1
Add comprehensive test coverage (reorganized) #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix syntax error in f-string in silicon.py - Fix NameError in pin_lock.py (change process_name to process)
- Add tests for SiliconStep and SiliconTop in test_steps_silicon.py - Add test_buffers.py for buffer component testing - Add test_cli.py for testing command line interface functionality
- Fix sortpins test in test_utils_additional.py - Add 'amaranth: UnusedElaboratable=no' directive to suppress warnings - Use mocks to avoid creating unused Module objects
- Update mock.toml to use process instead of processes - Add Path import to test_init.py - Fix Path comparison in test configuration - Update error message expectation in test_parse_config_file_invalid_schema
|
|
robtaylor
commented
Mar 18, 2025
Contributor
Author
robtaylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reorganized version of PR #55 with cleaner commit structure that groups related changes into logical commits:
Fixed code issues:
Added comprehensive test suite:
Fixed test utility functions:
Fixed test configurations:
Simplified test commands:
This PR supersedes #55 with the same changes but a cleaner commit history.