Skip to content

Conversation

@robtaylor
Copy link
Contributor

This is a reorganized version of PR #55 with cleaner commit structure that groups related changes into logical commits:

  1. Fixed code issues:

    • Fixed a syntax error in f-string in silicon.py
    • Fixed a NameError by changing 'process_name' to 'process' in pin_lock.py
  2. Added comprehensive test suite:

    • Created tests for SiliconStep and SiliconTop classes
    • Added buffer component testing
    • Added CLI functionality tests
  3. Fixed test utility functions:

    • Added 'amaranth: UnusedElaboratable=no' directive to suppress warnings
    • Fixed test utilities to properly work with mocks
    • Fixed sortpins test in test_utils_additional.py
  4. Fixed test configurations:

    • Updated test configs to use valid Process enum values
    • Added required fields to test configs
    • Fixed Path comparison in test_init.py
    • Updated error message expectations in tests
  5. Simplified test commands:

    • Updated test command configuration in pyproject.toml

This PR supersedes #55 with the same changes but a cleaner commit history.

- Fix syntax error in f-string in silicon.py
- Fix NameError in pin_lock.py (change process_name to process)
- Add tests for SiliconStep and SiliconTop in test_steps_silicon.py
- Add test_buffers.py for buffer component testing
- Add test_cli.py for testing command line interface functionality
- Fix sortpins test in test_utils_additional.py
- Add 'amaranth: UnusedElaboratable=no' directive to suppress warnings
- Use mocks to avoid creating unused Module objects
- Update mock.toml to use process instead of processes
- Add Path import to test_init.py
- Fix Path comparison in test configuration
- Update error message expectation in test_parse_config_file_invalid_schema
@github-actions
Copy link

github-actions bot commented Mar 18, 2025

Tests Skipped Failures Errors Time
88 0 💤 0 ❌ 0 🔥 1.730s ⏱️

@github-actions
Copy link

github-actions bot commented Mar 18, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-03-18 12:55 UTC

@robtaylor robtaylor marked this pull request as ready for review March 18, 2025 11:48
Copy link
Contributor Author

@robtaylor robtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@robtaylor robtaylor merged commit f5a0c13 into main Mar 18, 2025
4 checks passed
@robtaylor robtaylor deleted the reorganized-coverage-v2 branch March 18, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants