Skip to content

disable log streaming on wait #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

disable log streaming on wait #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 22 additions & 21 deletions chipflow_lib/steps/silicon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,27 +225,28 @@ def submit(self, rtlil_path, *, dry_run=False, wait=False):
# Wait before polling again
# time.sleep(10)
# Attempt to stream logs rather than time.sleep
try:
if stream_event_counter > 1:
logger.warning("Log streaming may have been interrupted. Some logs may be missing.")
logger.warning(f"Check {build_url}")
stream_event_counter += 1
with requests.get(
log_stream_url,
auth=(None, chipflow_api_key),
stream=True
) as log_resp:
if log_resp.status_code == 200:
for line in log_resp.iter_lines():
if line:
print(line.decode("utf-8")) # Print logs in real-time
sys.stdout.flush()
else:
logger.warning(f"Failed to stream logs: {log_resp.text}")
except requests.RequestException as e:
logger.error(f"Error while streaming logs: {e}")
pass
time.sleep(10) # Wait before polling again

# try:
# if stream_event_counter > 1:
# logger.warning("Log streaming may have been interrupted. Some logs may be missing.")
# logger.warning(f"Check {build_url}")
# stream_event_counter += 1
# with requests.get(
# log_stream_url,
# auth=(None, chipflow_api_key),
# stream=True
# ) as log_resp:
# if log_resp.status_code == 200:
# for line in log_resp.iter_lines():
# if line:
# print(line.decode("utf-8")) # Print logs in real-time
# sys.stdout.flush()
# else:
# logger.warning(f"Failed to stream logs: {log_resp.text}")
# except requests.RequestException as e:
# logger.error(f"Error while streaming logs: {e}")
# pass
time.sleep(30) # Wait before polling again
else:
# Log detailed information about the failed request
logger.error(f"Request failed with status code {resp.status_code}")
Expand Down
Loading