fix: 7317 support pg ssl#7366
Merged
Chocobozzz merged 6 commits intoChocobozzz:developfrom Feb 13, 2026
Merged
Conversation
Contributor
Author
|
do i need to add tests for this ? |
Chocobozzz
reviewed
Jan 22, 2026
config/default.yaml
Outdated
| # Each file path (ca, cert, key) MUST be absolute path | ||
| # | ||
| # Example: | ||
| # ssl: |
Owner
There was a problem hiding this comment.
I think that renaming this section to ssl_settings would be simpler to use & manage.
Contributor
Author
There was a problem hiding this comment.
I think that renaming this section to
ssl_settingswould be simpler to use & manage.
done, please review the changes
Chocobozzz
reviewed
Jan 30, 2026
config/default.yaml
Outdated
| port: 5432 | ||
| ssl: false | ||
| ssl_settings: | ||
| enabled: false |
Owner
There was a problem hiding this comment.
Please remove ssl_settings.enabled and keep ssl: boolean option to prevent configuration breaking change
Contributor
Author
There was a problem hiding this comment.
Should it look like this ?
...
port: 5432
ssl: false
ssl_settings:
reject_unauthorized: false
ca: '/absolute/path/to/server-certificates/root.crt'
cert: '/absolute/path/to/client-certificates/postgresql.crt'
key: '/absolute/path/to/client-key/postgresql.key'
...
Owner
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added the ability to specify TLS credentials for PostgreSQL.
Related issues
#7317
Has this been tested?