Fix tab => direction keys handling with disabled search#1260
Merged
Xon merged 1 commit intoChoices-js:mainfrom Feb 3, 2025
Merged
Fix tab => direction keys handling with disabled search#1260Xon merged 1 commit intoChoices-js:mainfrom
tab => direction keys handling with disabled search#1260Xon merged 1 commit intoChoices-js:mainfrom
Conversation
leofeyer
pushed a commit
to contao-components/choices
that referenced
this pull request
Feb 3, 2025
Description ----------- ### Description Supersedes the temporary hotfix contao/contao#7978 This provides the bugfix where tabbing away would not close the dropdown if we do not have the search enabled. Already opened a PR within choices Choices-js/Choices#1260 Commits ------- 527cbaf Fix `tab` => direction keys handling with disabled search
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a continuation of #1242
Whilst the PR in #1242 did work, we forgot the case that a choices may not have an input field when the search is disabled.
Without a search input, we are not closing the dropdown if it has been open when tabbing away.
Types of changes
Checklist