Skip to content

Remove ConfigureAwait from test code for consistency#47

Merged
Chris-Wolfgang merged 2 commits intodevelopfrom
copilot/sub-pr-8-yet-again
Feb 2, 2026
Merged

Remove ConfigureAwait from test code for consistency#47
Chris-Wolfgang merged 2 commits intodevelopfrom
copilot/sub-pr-8-yet-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 2, 2026

Description

Removed all ConfigureAwait(false) calls from test code in ChunkAsyncTests.cs. The .editorconfig disables S3216 for tests, indicating ConfigureAwait is unnecessary in test scenarios.

Changes:

  • Removed .ConfigureAwait(false) from enumerator.MoveNextAsync() in cancellation test (line 143)
  • Removed .ConfigureAwait(false) from Task.Delay() in CreateDelayedSource helper (line 171)

Type of change

  • Refactor

How Has This Been Tested?

  • All 14 ChunkAsync unit tests pass on .NET 8.0
  • CodeQL security scan passed with no alerts

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots (if applicable)

N/A

Additional context

This change addresses inconsistent use of ConfigureAwait in test code identified during review of #8. Test code does not require explicit synchronization context handling.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI mentioned this pull request Feb 2, 2026
14 tasks
@Chris-Wolfgang Chris-Wolfgang marked this pull request as ready for review February 2, 2026 01:28
Copilot AI review requested due to automatic review settings February 2, 2026 01:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
Copilot AI requested a review from Chris-Wolfgang as a code owner February 2, 2026 01:29
Copilot AI changed the title [WIP] Remove ConfigureAwait calls from test code for consistency Remove ConfigureAwait from test code for consistency Feb 2, 2026
@Chris-Wolfgang Chris-Wolfgang merged commit c7b7906 into develop Feb 2, 2026
@Chris-Wolfgang Chris-Wolfgang deleted the copilot/sub-pr-8-yet-again branch February 2, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants