Conversation
Fix CodeQL workflow build failure by using solution file instead of grep filtering
Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
…flow-file Fix find command syntax in CodeQL workflow
- Update .editorconfig with comprehensive C# formatting rules - Add format.ps1 PowerShell script for local formatting - Add README-FORMATTING.md documentation - Update pr.yaml workflow to check formatting - Apply formatting to existing code (2 files formatted) Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
- Add indent_size = 4 to global [*] section for consistency - Add end_of_line = lf to global [*] section to ensure LF line endings for all files - Addresses code review feedback Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
…g-enforcement Add automated code formatting enforcement
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
Add dotnet-format installation to PR workflow
…d CRLF line endings Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
…rmat-script [WIP] Fix parse error in format.ps1 for Windows PowerShell
Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
…se-error Fix Windows PowerShell compatibility via UTF-8 BOM encoding
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
|
@Chris-Wolfgang I've opened a new pull request, #61, to work on those changes. Once the pull request is ready, I'll request review from you. |
Removed setup instructions link from the documentation section.
Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
…-7e07-48b6-9eb9-7ebc01f98466 Remove broken SETUP.md reference from README
Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
# Conflicts: # README.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Chris-Wolfgang <210299580+Chris-Wolfgang@users.noreply.github.com>
Update README with correct documentation links and GitHub badge
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…-time Clarify dotnet format is built into .NET SDK and remove SETUP.md reference
Updated package version to 0.1.0-rc2 and fixed the PackageProjectUrl to the correct GitHub repository. Added configuration to include the README.md file from the root directory in the NuGet package.
Moved System.Runtime.CompilerServices to follow System.Threading for improved readability. No functional changes were made.
Updated Wolfgang.Extensions.IAsyncEnumerable.csproj to set the project version to 0.1.0, marking the transition from release candidate (rc2) to the official final release.
Rearranged the order of using statements for clarity; no functional changes.
| echo "Checking formatting for: $solution" | ||
| dotnet format "$solution" --verify-no-changes --verbosity diagnostic | ||
| else | ||
| echo "No solution file found, checking entire workspace" | ||
| dotnet format --verify-no-changes --verbosity diagnostic |
There was a problem hiding this comment.
dotnet format is invoked here, but the workflow doesn’t install/restore a known dotnet-format version (no tool manifest/tool restore step in repo). This makes CI dependent on whatever is (or isn’t) preinstalled on the runner. Consider adding a pinned tool (e.g., local tool manifest + dotnet tool restore, or explicit install) before calling dotnet format.
| @@ -0,0 +1,104 @@ | |||
| #!/usr/bin/env pwsh | |||
There was a problem hiding this comment.
This file starts with a UTF-8 BOM, so the shebang won’t be the first bytes in the file and won’t work for direct execution on *nix. Either drop the shebang (and document pwsh ./format.ps1 usage) or change the file encoding/line endings so the shebang can be honored.
| #!/usr/bin/env pwsh | |
| #!/usr/bin/env pwsh |
| await using var enumerator = source.GetAsyncEnumerator(token); | ||
|
|
||
| if (!await enumerator.MoveNextAsync()) | ||
| if (!await enumerator.MoveNextAsync().ConfigureAwait(false)) |
There was a problem hiding this comment.
Using ConfigureAwait(false) here contradicts the repo’s stated convention for library code to preserve synchronization context by default (see .editorconfig [src/**/*.cs] comments around lines 351-355). Either remove ConfigureAwait(false) to match that contract, or update the convention/docs so behavior is consistent.
| } | ||
|
|
||
| } while (await enumerator.MoveNextAsync()); | ||
| } while (await enumerator.MoveNextAsync().ConfigureAwait(false)); |
There was a problem hiding this comment.
Same as above: ConfigureAwait(false) here is inconsistent with the repo’s documented convention to preserve synchronization context by default for src/**/*.cs library code (.editorconfig lines ~351-355). Please align the implementation and convention one way or the other.
Description
Fixes/Complete # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist
Screenshots (if applicable)
Additional context