Skip to content

Comments

Replace any type with ExecOptions for type safety in vale-runner#12

Merged
ChrisChinchilla merged 2 commits intochrischinch/check_txtfrom
copilot/sub-pr-11
Nov 9, 2025
Merged

Replace any type with ExecOptions for type safety in vale-runner#12
ChrisChinchilla merged 2 commits intochrischinch/check_txtfrom
copilot/sub-pr-11

Conversation

Copy link
Contributor

Copilot AI commented Nov 9, 2025

Addresses type safety feedback from PR #11 where execOptions was typed as any, bypassing TypeScript's type checking.

Changes:

  • Import ExecOptions from child_process module
  • Type execOptions object with ExecOptions instead of any
// Before
import { exec } from "child_process";
const execOptions: any = {
  encoding: 'utf-8',
  cwd: process.cwd()
};

// After
import { exec, ExecOptions } from "child_process";
const execOptions: ExecOptions = {
  encoding: 'utf-8',
  cwd: process.cwd()
};

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: ChrisChinchilla <42080+ChrisChinchilla@users.noreply.github.com>
Copilot AI changed the title [WIP] Update check text command to address feedback from PR #11 Replace any type with ExecOptions for type safety in vale-runner Nov 9, 2025
Copilot AI requested a review from ChrisChinchilla November 9, 2025 09:48
@ChrisChinchilla ChrisChinchilla marked this pull request as ready for review November 9, 2025 10:04
@ChrisChinchilla ChrisChinchilla merged commit 314cc15 into chrischinch/check_txt Nov 9, 2025
3 checks passed
@ChrisChinchilla ChrisChinchilla deleted the copilot/sub-pr-11 branch November 9, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants