Fix server parsing correct .vale.ini inheritance#14
Merged
ChrisChinchilla merged 1 commit intomainfrom Dec 9, 2025
Merged
Conversation
theletterf
approved these changes
Dec 9, 2025
123d32e to
a106020
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Vale's configuration file (.vale.ini) inheritance by improving how the server searches for and uses configuration files. The key improvement allows Vale to perform its natural upward directory search from a file's location for check_file operations, while check_text operations fall back to the server's configured path. Additionally, the PR adds TypeScript type safety improvements by replacing any types with explicit type annotations.
Key changes:
- Added optional
config_pathparameter tocheck_fileandcheck_texttools, allowing users to override config discovery - Changed
check_fileto passconfig_pathonly when explicitly provided, enabling Vale's natural upward search from the file's directory - Replaced
anytypes with explicit TypeScript types (ExecOptions, proper error handling withunknown)
Reviewed changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vale-runner.ts | Improved TypeScript type safety by replacing any with ExecOptions and proper error handling with type narrowing |
| src/index.ts | Added config_path parameter to tool schemas and updated handler logic to support optional config overrides while preserving Vale's natural config discovery |
| build/index.js | Compiled JavaScript output reflecting the TypeScript changes |
| build/index.js.map | Updated source map for the compiled code |
| build/config.js | Compiled output with debug code that should be removed |
| build/config.js.map | Updated source map showing debug statement in compiled output |
| package-lock.json | Updated peer dependency markers for express and zod packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.