Skip to content

Comments

Fix server parsing correct .vale.ini inheritance#14

Merged
ChrisChinchilla merged 1 commit intomainfrom
chrischinch/vale-ini
Dec 9, 2025
Merged

Fix server parsing correct .vale.ini inheritance#14
ChrisChinchilla merged 1 commit intomainfrom
chrischinch/vale-ini

Conversation

@ChrisChinchilla
Copy link
Owner

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes Vale's configuration file (.vale.ini) inheritance by improving how the server searches for and uses configuration files. The key improvement allows Vale to perform its natural upward directory search from a file's location for check_file operations, while check_text operations fall back to the server's configured path. Additionally, the PR adds TypeScript type safety improvements by replacing any types with explicit type annotations.

Key changes:

  • Added optional config_path parameter to check_file and check_text tools, allowing users to override config discovery
  • Changed check_file to pass config_path only when explicitly provided, enabling Vale's natural upward search from the file's directory
  • Replaced any types with explicit TypeScript types (ExecOptions, proper error handling with unknown)

Reviewed changes

Copilot reviewed 4 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/vale-runner.ts Improved TypeScript type safety by replacing any with ExecOptions and proper error handling with type narrowing
src/index.ts Added config_path parameter to tool schemas and updated handler logic to support optional config overrides while preserving Vale's natural config discovery
build/index.js Compiled JavaScript output reflecting the TypeScript changes
build/index.js.map Updated source map for the compiled code
build/config.js Compiled output with debug code that should be removed
build/config.js.map Updated source map showing debug statement in compiled output
package-lock.json Updated peer dependency markers for express and zod packages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ChrisChinchilla ChrisChinchilla merged commit bb12dfd into main Dec 9, 2025
2 checks passed
@ChrisChinchilla ChrisChinchilla deleted the chrischinch/vale-ini branch December 9, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants