Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a0153f76e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub fn sigpipe_was_ignored() -> bool { | ||
| SIGPIPE_WAS_IGNORED.load(Ordering::Acquire) | ||
| let was_ignored = SIGPIPE_WAS_IGNORED.load(Ordering::Acquire); | ||
| eprintln!("[SIGPIPE-DEBUG] sigpipe_was_ignored() returning: {}", was_ignored); |
There was a problem hiding this comment.
sigpipe_was_ignored() now writes to stderr on every call, and the proc-macro wrapper invokes this during startup for Unix utilities (src/uucore_procs/src/lib.rs), so normal command runs will emit debug noise even when there is no warning/error condition. This is a user-visible behavior regression that can break scripts and tests that expect clean stderr unless an actual diagnostic is produced.
Useful? React with 👍 / 👎.
src/uu/dd/src/dd.rs
Outdated
| /// If there is a problem reading from the input or writing to | ||
| /// this output. | ||
| fn dd_copy(mut i: Input, o: Output) -> io::Result<()> { | ||
| eprintln!("[DD-DEBUG] dd_copy() starting"); |
There was a problem hiding this comment.
dd_copy() now unconditionally emits [DD-DEBUG] messages to stderr, so dd produces extra output regardless of status= settings. This changes the CLI contract and can break automation that relies on stderr containing only requested progress/error output (for example status=none runs that are expected to stay silent).
Useful? React with 👍 / 👎.
| UTIL_LIST=$("${ME_dir}"/show-utils.sh ${FEATURES_OPTION}) | ||
| # UTIL_LIST=$("${ME_dir}"/show-utils.sh ${FEATURES_OPTION}) | ||
| # DEBUG: Only test dd for faster iteration | ||
| UTIL_LIST="dd" |
There was a problem hiding this comment.
The coverage script now hardcodes UTIL_LIST="dd" and comments out the normal utility discovery, so coverage jobs only execute dd tests instead of the full utility set. This materially corrupts CI coverage signals by masking regressions in all other utilities and makes the coverage workflow results non-representative.
Useful? React with 👍 / 👎.
ChrisDryden
force-pushed
the
eco/test-dd-branch3-debug
branch
3 times, most recently
from
40205a1 to
41fea00
Compare
ChrisDryden
force-pushed
the
eco/test-dd-branch3-debug
branch
5 times, most recently
from
b98d912 to
33e3b2c
Compare
ChrisDryden
force-pushed
the
eco/test-dd-branch3-debug
branch
from
33e3b2c to
ed0a288
Compare
2 participants
No description provided.