Conversation
ChrisDryden
force-pushed
the
eco/test-dd-branch3
branch
from
8235354 to
c07f21f
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8235354e21
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # UTIL_LIST=$("${ME_dir}"/show-utils.sh ${FEATURES_OPTION}) | ||
| # DEBUG: Only test dd for faster iteration | ||
| UTIL_LIST="dd" |
There was a problem hiding this comment.
The coverage script now hardcodes UTIL_LIST="dd", so CI coverage only exercises dd and skips every other utility that show-utils.sh would normally enumerate. This makes coverage reports materially incomplete and can let regressions in non-dd utilities ship undetected because their tests are never run in this workflow.
Useful? React with 👍 / 👎.
| - { os: ubuntu-latest , features: dd, toolchain: nightly, run: 1 } | ||
| - { os: ubuntu-latest , features: dd, toolchain: nightly, run: 2 } | ||
| - { os: ubuntu-latest , features: dd, toolchain: nightly, run: 3 } |
There was a problem hiding this comment.
The workflow matrix is restricted to repeated Ubuntu jobs with features: dd, which removes cross-platform signal from this pipeline and limits exercised code paths to a single utility. Combined with the workflow deletions in this commit, this substantially weakens CI’s ability to catch platform-specific and utility-specific breakages before merge.
Useful? React with 👍 / 👎.
2 participants
No description provided.