Replaces use notifications setting with low battery notification setting #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streamlines preference management by passing the extension object directly to relevant components. This change avoids redundant access to settings and improves code readability. The openPreferences call is now directly accessible from the HeadsetControl class. Closes the quick settings menu after opening preferences, ensuring a smoother user experience.
Updates the notification setting to specifically address low battery alerts. This change enhances clarity by renaming the "use-notifications" setting to "notification-low-battery", reflecting its intended purpose: sending a notification when the headset battery is low. It also removes general refresh notifications to only notify about battery issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change renames the "use-notifications" setting to "notification-low-battery".
Use notifications was mainly annoying and we miss a notication when battery is low.