-
Notifications
You must be signed in to change notification settings - Fork 390
allow different os-releases and hyprland setup #1013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
e009ef0
4b72e84
fc6acb2
45d2995
b6bb227
5391ade
63e0b82
b977560
f8900e4
a776682
c173596
d872d84
599ad20
9e34347
b83cee7
d69c4e1
5731a9b
ad05a0d
7fa4d2d
2b17c04
f37778d
7ec3333
6e20e33
e5fdbff
072c08d
01535e2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| #!/bin/bash | ||
|
|
||
ChrisTitusTech marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| # Check if base-devel is installed, install if not | ||
ChrisTitusTech marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| if ! pacman -Q base-devel &>/dev/null; then | ||
| echo "Installing base-devel..." | ||
ChrisTitusTech marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| sudo pacman -S --noconfirm base-devel | ||
ChrisTitusTech marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| fi | ||
|
|
||
| git clone --depth=1 https://github.com/JaKooLit/Arch-Hyprland.git ~/Arch-Hyprland | ||
ChrisTitusTech marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| cd ~/Arch-Hyprland | ||
|
Check warning on line 10 in core/tabs/system-setup/arch/hyprland-kool.sh
|
||
ChrisTitusTech marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| chmod +x install.sh | ||
| ./install.sh | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| #!/bin/bash | ||
|
|
||
ChrisTitusTech marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| echo "Hyprland Kool" | ||
ChrisTitusTech marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| git clone --depth=1 https://github.com/JaKooLit/Debian-Hyprland.git ~/Debian-Hyprland | ||
|
||
| cd ~/Debian-Hyprland | ||
|
Check warning on line 5 in core/tabs/system-setup/debian/hyprland-kool-deb.sh
|
||
ChrisTitusTech marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| chmod +x install.sh | ||
| ./install.sh | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| #!/bin/bash | ||
|
|
||
ChrisTitusTech marked this conversation as resolved.
Show resolved
Hide resolved
ChrisTitusTech marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| git clone --depth=1 https://github.com/JaKooLit/Fedora-Hyprland.git ~/Fedora-Hyprland | ||
ChrisTitusTech marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| cd ~/Fedora-Hyprland | ||
|
Check warning on line 4 in core/tabs/system-setup/fedora/hyprland-kool-fed.sh
|
||
ChrisTitusTech marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| chmod +x install.sh | ||
| ./install.sh | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| #!/bin/bash | ||
|
|
||
| echo "Hyprland Kool" | ||
ChrisTitusTech marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| git clone -b 24.04 --depth=1 https://github.com/JaKooLit/Ubuntu-Hyprland.git ~/Ubuntu-Hyprland-24.04 | ||
| cd ~/Ubuntu-Hyprland-24.04 | ||
|
Check warning on line 5 in core/tabs/system-setup/ubuntu/hyprland-kool-ubuntu24.sh
|
||
| chmod +x install.sh | ||
| ./install.sh | ||

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this what the previous file precondition was doing? See linux neptune for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me test that out, for some odd reason I thought that was just matching the entire value of the file. It was late and I probably just missed this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it iterated through values[] and ensured each was contained within the file.
I feel as though the 'contains' in the FileContains variant also is redundant, given values[] already stores strings to validate.
I would personally keep the previous implementation of the File precondition (perhaps renaming it to FileContains) and create a new FileExists precondition, which would match the pattern with the existing CommandExists.