Skip to content

DWM-Titus: add install/uninstall flow, fixes, and lint/doc updates#1237

Open
Abs313a wants to merge 3 commits intoChrisTitusTech:mainfrom
Abs313a:dwm-fix
Open

DWM-Titus: add install/uninstall flow, fixes, and lint/doc updates#1237
Abs313a wants to merge 3 commits intoChrisTitusTech:mainfrom
Abs313a:dwm-fix

Conversation

@Abs313a
Copy link
Copy Markdown
Contributor

@Abs313a Abs313a commented Mar 27, 2026

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Security patch
  • UI/UX improvement

Description

This PR improves the DWM-Titus workflow in Linutil by making install/uninstall safer, more predictable, and easier to recover from, while also updating user docs and cleaning lint warnings across the repo.

DWM-Titus script improvements

  • Added an interactive menu to dwmtitus-setup.sh:
    • Install
    • Uninstall
    • Quit
  • Refactored install flow into explicit functions (installDWM, uninstallDWM, post_install_fixups, prompt_reboot).

Post-install reliability fixes

  • Ensures DWM session entry exists for display managers:
    • creates /usr/share/xsessions
    • copies dwm.desktop
    • sets proper permissions (644)
  • Handles SDDM autologin configs more robustly:
    • detects autologin config files in /etc/sddm.conf.d
    • moves them out to /etc/sddm-disabled to prevent forced autologin
    • Fixes ownership of ~/.config/dwm-titus to the actual user to avoid runtime permission failures after install.
  • Adds reboot prompt.

Package conflict handling (Arch)

  • Avoids networkmanager vs networkmanager-iwd conflict:
    • if networkmanager-iwd is already installed, installs/uses that instead of networkmanager.

Uninstall behavior

  • Added explicit uninstall path that removes:
    • DWM binary/man/session entry (via make uninstall + cleanup)
    • copied scripts and config artifacts created by DWM-Titus
    • local DWM-Titus repository and related config directory.

SSH script cleanup

  • Fixed quoting/remote-command issues in core/tabs/utils/ssh.sh to satisfy shellcheck.
  • Added targeted SC2029 suppression where client-side expansion for remote execution is intentional.
  • No feature behavior change intended; this is a reliability/lint cleanup for the SSH helper paths.

Issues / other PRs related

Screenshots (if applicable)

@Abs313a Abs313a requested a review from ChrisTitusTech as a code owner March 27, 2026 11:12
@github-actions github-actions bot added bug documentation rust Pull requests that update rust code script UI update labels Mar 27, 2026
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$NM_PACKAGE kept + merged package additions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug documentation rust Pull requests that update rust code script UI update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant