Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Sep 17, 2024

Merge with #442 #443 #454

Type of Change

  • New feature
  • Refactoring

Description

#422 does this slightly correct; I have added the missing ones that weren't included in his PR

Gaming-setup & Aur helpers were skipped due to #382 and #380 which include refactoring for both of these functionality

ONLY after I made my 3 PRs did he decide to implement MY fixes.. before: 61cddeb after: 100fc58

My commits are VERIFIED, meaning everything that I do contains MY work. Take a look at these 2 commits and decide for your self. The first commit contained INCOMPLETE functionality and only after making my 3 PRs that fixed those issues did he decide to grab the changes in my commits and then implement them in his.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • My changes generate no errors/warnings/merge conflicts.

This was referenced Sep 17, 2024
@ghost ghost changed the title Change apt-get's & use nala along with apt | Competing with PR #422 Change apt-get's & use nala along with apt Sep 17, 2024
@jeevithakannan2
Copy link
Contributor

@ChrisTitusTech

Caution

This PR is not tested.
This implementation is wrong and will not use nala.
Changing apt-get with apt is not recommended when running scripts

@ghost
Copy link
Author

ghost commented Sep 17, 2024

Changing apt-get with apt is not recommended when running scripts

This PR is tested. Using apt instead of apt-get is better as it's newer and more developed: apt-get is old and will deprecate eventually, Nala will work; as this is already implemented some-what in the existing scripts.

@ghost
Copy link
Author

ghost commented Sep 17, 2024

Your criticism is not appreciated when you copied my whole implementation into YOUR PR, and DID not give credit.. Unlike you I REWROTE everything. Here are the commits on your PR if needed: before: 61cddeb after: 100fc58

@ghost
Copy link
Author

ghost commented Sep 17, 2024

image

Here is Adam's input on these PRs

@koibtw
Copy link
Collaborator

koibtw commented Sep 17, 2024

@jeevithakannan2

This PR is not tested.

You have no way of knowing this. Baseless accusations, here we go again..

This implementation is wrong and will not use nala.

?? #422 (comment)

Changing apt-get with apt is not recommended when running scripts

I already proved you wrong in #422 (comment).

@koibtw
Copy link
Collaborator

koibtw commented Sep 17, 2024

I think #440 #442 #443 approach this better. #422 is clearly copying the changes from them into his own implementation.

@ghost ghost mentioned this pull request Sep 18, 2024
5 tasks
@ChrisTitusTech
Copy link
Owner

For scripting apt-get will be used.

@ghost ghost deleted the refactor-apt-gets branch September 18, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants