This repository was archived by the owner on Aug 29, 2024. It is now read-only.
Add device to Home Assistant auto-discovery#39
Open
PeteBa wants to merge 1 commit intoChristianKuehnel:masterfrom
Open
Add device to Home Assistant auto-discovery#39PeteBa wants to merge 1 commit intoChristianKuehnel:masterfrom
PeteBa wants to merge 1 commit intoChristianKuehnel:masterfrom
Conversation
|
@PeteBa To respond to your question regarding other manufacturers: I'm pretty sure a lot of the other brands on Amazon at least (for example, OLLIVAN) use the exact same internals as the Xiaomi products. I was able to connect my OLLIVAN sensors without any difficulty. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
unique_idto the discovery payload so that sensors are persisted in the Entity Registry. In addition, this adds Device information so that you can see all of the entities associated with each physical MiFlora device.@ChristianKuehnel , I have assumed that the only devices recognised are Xiaomi (Line 304). Is that correct or does the gateway also detect other manufacturers ? Also, I see in the library that
MiFloraPoller.name()does not retrieve from cache but makes an additional bluetooth connection. Would it be worth cachingnamein the same way thatfirmware_versionis cached ?