Skip to content

Add GD and various image format support#84

Open
mmatsoo wants to merge 6 commits intomainfrom
gh-83-add-image-support
Open

Add GD and various image format support#84
mmatsoo wants to merge 6 commits intomainfrom
gh-83-add-image-support

Conversation

@mmatsoo
Copy link
Member

@mmatsoo mmatsoo commented Jul 3, 2025

Description

This PR was opened a long time ago (July 2025) as an effort to get all necessary support into our Docker image, to support the various optimizations used by Drupal when it works with newer uploaded media types. (e.g. avif)

Motivation / Context

#83

Copy link
Contributor

@apotek apotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing builds, probably due to software-properties-common package.

@mmatsoo
Copy link
Member Author

mmatsoo commented Mar 2, 2026

@apotek Many thanks for the review! I removed software-properties-common, but added in google-chrome-stable because Gemini noted that we have the "Chrome repo and signing key" added, but we don't include chrome in the package list.

Google Chrome is added to apt sources but never installed
You add the Chrome repo and signing key, then run apt-get install — but google-chrome-stable is not in the package list. This is either a bug (you meant to install it) or dead code. If it's for Puppeteer/browser testing, add google-chrome-stable. If not, remove the repo setup.

TBH, I don't know if we need it or not. Segal uses Pupeteer in its tests, but they've been running for years without it. Maybe @agarzola has thoughts?

@mmatsoo mmatsoo requested a review from apotek March 2, 2026 10:21
@mmatsoo mmatsoo self-assigned this Mar 2, 2026
Copy link
Contributor

@apotek apotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is buy-in for this being our new standard, all is good to go.

I suggested a voluntary edit to alphabetize your list of dependencies for easier future maintenance, but non-blocking.

jpegoptim \
pngquant \
libwebp-dev \
libavif-dev \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a big fan of alphabetizing lists of things so its easier to see if something is there or not. Minor nudge.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apotek Yep, happy to do that kind of clean up. It actually resulted in adding Chrome stable to the nginx Dockerfile, too. And the nginx version was also missing some of the image-related packages we have in the apache version so now both versions should have equivalent support.

@apotek
Copy link
Contributor

apotek commented Mar 3, 2026

I see we have never instituted releases of docker-images. Should we?

I'm fine with you merging this in. Maybe pre-announce that you will so people have a few days to prepare for the change to their projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants