Conversation
apotek
left a comment
There was a problem hiding this comment.
This is failing builds, probably due to software-properties-common package.
|
@apotek Many thanks for the review! I removed
TBH, I don't know if we need it or not. Segal uses Pupeteer in its tests, but they've been running for years without it. Maybe @agarzola has thoughts? |
apotek
left a comment
There was a problem hiding this comment.
If there is buy-in for this being our new standard, all is good to go.
I suggested a voluntary edit to alphabetize your list of dependencies for easier future maintenance, but non-blocking.
services/php-apache-node/Dockerfile
Outdated
| jpegoptim \ | ||
| pngquant \ | ||
| libwebp-dev \ | ||
| libavif-dev \ |
There was a problem hiding this comment.
I am a big fan of alphabetizing lists of things so its easier to see if something is there or not. Minor nudge.
There was a problem hiding this comment.
@apotek Yep, happy to do that kind of clean up. It actually resulted in adding Chrome stable to the nginx Dockerfile, too. And the nginx version was also missing some of the image-related packages we have in the apache version so now both versions should have equivalent support.
|
I see we have never instituted releases of docker-images. Should we? I'm fine with you merging this in. Maybe pre-announce that you will so people have a few days to prepare for the change to their projects. |
Description
This PR was opened a long time ago (July 2025) as an effort to get all necessary support into our Docker image, to support the various optimizations used by Drupal when it works with newer uploaded media types. (e.g.
avif)Motivation / Context
#83