GH-8 Add dump_only_these_tables input

[mmatsoo]

Description

@markdorison @adamzimmermann This PR adds an optional input, dump_only_these_tables that can take an arbitrary list of table names, separated by spaces.

The entrypoint.sh script loops through the list of table names and concatenates them into the platform db:dump command. If the input variable is missing or empty, the script does not mind and continues to run, dumping the entire DB, as expected.

Testing

Tested locally.

Related Ticket

• https://github.com/ChromaticHQ/benz-tickets/issues/2062

[adamzimmermann]

@mmatsoo I see you still pushing work to this. I'm guessing there are bugs to work out still? Anything I can help with?

[mmatsoo]

@adamzimmermann This was working fine, locally, but shellcheck doesn't like how I'm inserting the --table options, which come from the config. You can see from the commits I've tried:

• Try bash shell
• Remove double quotes
• Change to sh and try with array
• Change to bash again

In short, whatever works locally is not liked by shellcheck and when I make changes to fix shellcheck warnings, the script no longer works locally. 🤷

[adamzimmermann]

@mmatsoo can you revert it to the working state or point me to the commit and then share what shell check is barking about (I guess I can see it in the check output)?

We could disable shell-check for the troublesome line if we are really stuck. 🙁

[apotek]

While it would be preferable to pass the list of tables as a list rather than string, this works and is good enough and has the virtue of simplicity. Nice work.

[apotek]

Really cool use of shell "arrays" here with [*] below.... That was really smart.

[mmatsoo]

I think "smart" is really just finding something to copy/paste from StackOverflow.

[apotek]

I guess the only thing remaining here is make shellcheck shut up.

I assume this does not work?:

"${DUMP_ONLY_THESE_TABLES[*]}"

In my shell(s) it works (both in zsh and then in bash and in sh). Herewith my sh session:

% echo $SHELL
/bin/zsh
% sh
sh-3.2$ DUMP_ONLY_THESE_TABLES=""
sh-3.2$ for table in table_one table_two table_three;do

DUMP_ONLY_THESE_TABLES+=("--table $table")
done
sh-3.2$ echo ${DUMP_ONLY_THESE_TABLES[]}
--table table_one --table table_two --table table_three
sh-3.2$ echo "${DUMP_ONLY_THESE_TABLES[]}"
--table table_one --table table_two --table table_three

That's the only blocker here. We need to get shellcheck to pass this.

If my suggestion doesn't work, I wonder if we can remove the -l from the sh invocation at the top of the script. Or, convert the script to bash.

[mmatsoo]

@apotek FWIW - the shebang is from what we use in the main branch. I checked documenation and it has the exact same shebang in its example.

Copy/paste from documentation page

#!/bin/sh -l

echo "Hello $1"
time=$(date)
echo "time=$time" >> $GITHUB_OUTPUT

[apotek]

@apotek FWIW - the shebang is from what we use in the main branch. I checked documenation and it has the exact same shebang in its example.

In my testing, this worked

"${DUMP_ONLY_THESE_TABLES[*]}"

even with no change to the shebang.