Skip to content

Commit 12eb494

Browse files
chore(deps-dev): bump chrome-devtools-frontend from 1.0.1524741 to 1.0.1531367 in the chrome-devtools-frontend group (#429)
Bumps the chrome-devtools-frontend group with 1 update: [chrome-devtools-frontend](https://github.com/ChromeDevTools/devtools-frontend). Updates `chrome-devtools-frontend` from 1.0.1524741 to 1.0.1531367 <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ChromeDevTools/devtools-frontend/commit/6f4312a899ff0af345ba1a51ba719d0c0a1bf5d2"><code>6f4312a</code></a> Update DevTools DEPS (trusted)</li> <li><a href="https://github.com/ChromeDevTools/devtools-frontend/commit/03ffc0b5fc5f07fdde976d2ad47670138bf5cca7"><code>03ffc0b</code></a> Update Chrome (for Testing) PIN</li> <li><a href="https://github.com/ChromeDevTools/devtools-frontend/commit/a717fef99f53ea02dbc91867206546800ae52f69"><code>a717fef</code></a> [RPP] Actually hide Workspaces in trace app</li> <li><a href="https://github.com/ChromeDevTools/devtools-frontend/commit/9ac40d2b0c7d7cf9d6493905df1a72dd4b90803b"><code>9ac40d2</code></a> Increase performance tests timeout</li> <li><a href="https://github.com/ChromeDevTools/devtools-frontend/commit/ca1486a6501f6926009969c0c1aa3a577ec93210"><code>ca1486a</code></a> Create throttling/blocking conditions from the context menu</li> <li><a href="https://github.com/ChromeDevTools/devtools-frontend/commit/19213823907008766d5759b8b25feca602ea93fa"><code>1921382</code></a> [Console Insights Teasers] Add error state</li> <li><a href="https://github.com/ChromeDevTools/devtools-frontend/commit/2678dc3548a7fbb9aa80455ffa0dc13fd0714e86"><code>2678dc3</code></a> Update DevTools DEPS (trusted)</li> <li><a href="https://github.com/ChromeDevTools/devtools-frontend/commit/db045b91de4fa65c651bda1968ad882f78160a26"><code>db045b9</code></a> [Console Insights Teasers] Handle slowness</li> <li><a href="https://github.com/ChromeDevTools/devtools-frontend/commit/a95ceaf384f7917fe9e3a2aac3d10000a8f14fc6"><code>a95ceaf</code></a> Fix console sidebar filter selection</li> <li><a href="https://github.com/ChromeDevTools/devtools-frontend/commit/a32c47b13d74ba38f478f3369d57bf9647a458b1"><code>a32c47b</code></a> Support individual request throttling in the request blocking panel</li> <li>Additional commits viewable in <a href="https://github.com/ChromeDevTools/devtools-frontend/compare/v1.0.1524741...v1.0.1531367">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by [GitHub Actions](<a href="https://www.npmjs.com/~GitHub">https://www.npmjs.com/~GitHub</a> Actions), a new releaser for chrome-devtools-frontend since your current version.</p> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=chrome-devtools-frontend&package-manager=npm_and_yarn&previous-version=1.0.1524741&new-version=1.0.1531367)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Rudenko <[email protected]>
1 parent 70cd290 commit 12eb494

File tree

8 files changed

+71
-33
lines changed

8 files changed

+71
-33
lines changed

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"@types/yargs": "^17.0.33",
5252
"@typescript-eslint/eslint-plugin": "^8.43.0",
5353
"@typescript-eslint/parser": "^8.43.0",
54-
"chrome-devtools-frontend": "1.0.1524741",
54+
"chrome-devtools-frontend": "1.0.1532884",
5555
"core-js": "3.46.0",
5656
"debug": "4.4.3",
5757
"eslint": "^9.35.0",

scripts/post-build.ts

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ import * as path from 'node:path';
99

1010
import tsConfig from '../tsconfig.json' with {type: 'json'};
1111

12+
import {sed} from './sed.ts';
13+
1214
const BUILD_DIR = path.join(process.cwd(), 'build');
1315

1416
/**
@@ -20,22 +22,6 @@ function writeFile(filePath: string, content: string): void {
2022
fs.writeFileSync(filePath, content, 'utf-8');
2123
}
2224

23-
/**
24-
* Replaces content in a file.
25-
* @param filePath The path to the file.
26-
* @param find The regex to find.
27-
* @param replace The string to replace with.
28-
*/
29-
function sed(filePath: string, find: RegExp, replace: string): void {
30-
if (!fs.existsSync(filePath)) {
31-
console.warn(`File not found for sed operation: ${filePath}`);
32-
return;
33-
}
34-
const content = fs.readFileSync(filePath, 'utf-8');
35-
const newContent = content.replace(find, replace);
36-
fs.writeFileSync(filePath, newContent, 'utf-8');
37-
}
38-
3925
/**
4026
* Ensures that licenses for third party files we use gets copied into the build/ dir.
4127
*/

scripts/prepare.ts

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
import {rm} from 'node:fs/promises';
88
import {resolve} from 'node:path';
99

10+
import {sed} from './sed.ts';
11+
1012
const projectRoot = process.cwd();
1113

1214
const filesToRemove = [
@@ -28,6 +30,28 @@ async function main() {
2830
process.exit(1);
2931
}
3032
}
33+
// TODO: remove once https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7072054 is available.
34+
sed(
35+
'node_modules/chrome-devtools-frontend/front_end/core/sdk/NetworkManager.ts',
36+
`declare global {
37+
// TS typedefs are not up to date
38+
interface URLPattern {
39+
hash: string;
40+
hostname: string;
41+
password: string;
42+
pathname: string;
43+
port: string;
44+
protocol: string;
45+
search: string;
46+
username: string;
47+
hasRegExpGroups: boolean;
48+
test(url: string): boolean;
49+
}
50+
/* eslint-disable-next-line @typescript-eslint/naming-convention */
51+
var URLPattern: {prototype: URLPattern, new (input: string): URLPattern};
52+
}`,
53+
'',
54+
);
3155
console.log('Clean up of chrome-devtools-frontend complete.');
3256
}
3357

scripts/sed.ts

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
/**
2+
* @license
3+
* Copyright 2025 Google LLC
4+
* SPDX-License-Identifier: Apache-2.0
5+
*/
6+
7+
import * as fs from 'node:fs';
8+
9+
/**
10+
* Replaces content in a file.
11+
* @param filePath The path to the file.
12+
* @param find The regex to find.
13+
* @param replace The string to replace with.
14+
*/
15+
export function sed(
16+
filePath: string,
17+
find: RegExp | string,
18+
replace: string,
19+
): void {
20+
if (!fs.existsSync(filePath)) {
21+
console.warn(`File not found for sed operation: ${filePath}`);
22+
return;
23+
}
24+
const content = fs.readFileSync(filePath, 'utf-8');
25+
const newContent = content.replace(find, replace);
26+
fs.writeFileSync(filePath, newContent, 'utf-8');
27+
}

src/DevToolsConnectionAdapter.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@
44
* SPDX-License-Identifier: Apache-2.0
55
*/
66

7-
import {Connection} from '../node_modules/chrome-devtools-frontend/front_end/core/protocol_client/InspectorBackend.js';
7+
import {ConnectionTransport as DevToolsConnectionTransport} from '../node_modules/chrome-devtools-frontend/front_end/core/protocol_client/ConnectionTransport.js';
88

99
import {type ConnectionTransport} from './third_party/index.js';
1010

1111
/**
1212
* Allows a puppeteer {@link ConnectionTransport} to act like a DevTools {@link Connection}.
1313
*/
14-
export class DevToolsConnectionAdapter extends Connection {
14+
export class DevToolsConnectionAdapter extends DevToolsConnectionTransport {
1515
#transport: ConnectionTransport | null;
1616
#onDisconnect: ((arg0: string) => void) | null = null;
1717

tests/tools/performance.test.js.snapshot

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ We can break this time down into the 4 phases that combine to make the LCP time:
3838
## Estimated savings: none
3939

4040
## External resources:
41+
- https://developer.chrome.com/docs/performance/insights/lcp-breakdown
4142
- https://web.dev/articles/lcp
4243
- https://web.dev/articles/optimize-lcp
4344
`;
@@ -66,31 +67,31 @@ Metrics (lab / observed):
6667
Metrics (field / real users): n/a – no data for this page in CrUX
6768
Available insights:
6869
- insight name: LCPBreakdown
69-
description: Each [subpart has specific improvement strategies](https://web.dev/articles/optimize-lcp#lcp-breakdown). Ideally, most of the LCP time should be spent on loading the resources, not within delays.
70+
description: Each [subpart has specific improvement strategies](https://developer.chrome.com/docs/performance/insights/lcp-breakdown). Ideally, most of the LCP time should be spent on loading the resources, not within delays.
7071
relevant trace bounds: {min: 122410996889, max: 122411126100}
7172
example question: Help me optimize my LCP score
7273
example question: Which LCP phase was most problematic?
7374
example question: What can I do to reduce the LCP time for this page load?
7475
- insight name: LCPDiscovery
75-
description: Optimize LCP by making the LCP image [discoverable](https://web.dev/articles/optimize-lcp#1_eliminate_resource_load_delay) from the HTML immediately, and [avoiding lazy-loading](https://web.dev/articles/lcp-lazy-loading)
76+
description: [Optimize LCP](https://developer.chrome.com/docs/performance/insights/lcp-discovery) by making the LCP image discoverable from the HTML immediately, and avoiding lazy-loading
7677
relevant trace bounds: {min: 122411004828, max: 122411055039}
7778
example question: Suggest fixes to reduce my LCP
7879
example question: What can I do to reduce my LCP discovery time?
7980
example question: Why is LCP discovery time important?
8081
- insight name: RenderBlocking
81-
description: Requests are blocking the page's initial render, which may delay LCP. [Deferring or inlining](https://web.dev/learn/performance/understanding-the-critical-path#render-blocking_resources) can move these network requests out of the critical path.
82+
description: Requests are blocking the page's initial render, which may delay LCP. [Deferring or inlining](https://developer.chrome.com/docs/performance/insights/render-blocking) can move these network requests out of the critical path.
8283
relevant trace bounds: {min: 122411037528, max: 122411053852}
8384
example question: Show me the most impactful render blocking requests that I should focus on
8485
example question: How can I reduce the number of render blocking requests?
8586
- insight name: DocumentLatency
86-
description: Your first network request is the most important. Reduce its latency by avoiding redirects, ensuring a fast server response, and enabling text compression.
87+
description: Your first network request is the most important. [Reduce its latency](https://developer.chrome.com/docs/performance/insights/document-latency) by avoiding redirects, ensuring a fast server response, and enabling text compression.
8788
relevant trace bounds: {min: 122410998910, max: 122411043781}
8889
estimated metric savings: FCP 0 ms, LCP 0 ms
8990
estimated wasted bytes: 77.1 kB
9091
example question: How do I decrease the initial loading time of my page?
9192
example question: Did anything slow down the request for this document?
9293
- insight name: ThirdParties
93-
description: 3rd party code can significantly impact load performance. [Reduce and defer loading of 3rd party code](https://web.dev/articles/optimizing-content-efficiency-loading-third-party-javascript/) to prioritize your page's content.
94+
description: 3rd party code can significantly impact load performance. [Reduce and defer loading of 3rd party code](https://developer.chrome.com/docs/performance/insights/third-parties) to prioritize your page's content.
9495
relevant trace bounds: {min: 122411037881, max: 122416229595}
9596
example question: Which third parties are having the largest impact on my page performance?
9697

tests/trace-processing/parse.test.js.snapshot

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,31 +15,31 @@ Metrics (lab / observed):
1515
Metrics (field / real users): n/a – no data for this page in CrUX
1616
Available insights:
1717
- insight name: LCPBreakdown
18-
description: Each [subpart has specific improvement strategies](https://web.dev/articles/optimize-lcp#lcp-breakdown). Ideally, most of the LCP time should be spent on loading the resources, not within delays.
18+
description: Each [subpart has specific improvement strategies](https://developer.chrome.com/docs/performance/insights/lcp-breakdown). Ideally, most of the LCP time should be spent on loading the resources, not within delays.
1919
relevant trace bounds: {min: 122410996889, max: 122411126100}
2020
example question: Help me optimize my LCP score
2121
example question: Which LCP phase was most problematic?
2222
example question: What can I do to reduce the LCP time for this page load?
2323
- insight name: LCPDiscovery
24-
description: Optimize LCP by making the LCP image [discoverable](https://web.dev/articles/optimize-lcp#1_eliminate_resource_load_delay) from the HTML immediately, and [avoiding lazy-loading](https://web.dev/articles/lcp-lazy-loading)
24+
description: [Optimize LCP](https://developer.chrome.com/docs/performance/insights/lcp-discovery) by making the LCP image discoverable from the HTML immediately, and avoiding lazy-loading
2525
relevant trace bounds: {min: 122411004828, max: 122411055039}
2626
example question: Suggest fixes to reduce my LCP
2727
example question: What can I do to reduce my LCP discovery time?
2828
example question: Why is LCP discovery time important?
2929
- insight name: RenderBlocking
30-
description: Requests are blocking the page's initial render, which may delay LCP. [Deferring or inlining](https://web.dev/learn/performance/understanding-the-critical-path#render-blocking_resources) can move these network requests out of the critical path.
30+
description: Requests are blocking the page's initial render, which may delay LCP. [Deferring or inlining](https://developer.chrome.com/docs/performance/insights/render-blocking) can move these network requests out of the critical path.
3131
relevant trace bounds: {min: 122411037528, max: 122411053852}
3232
example question: Show me the most impactful render blocking requests that I should focus on
3333
example question: How can I reduce the number of render blocking requests?
3434
- insight name: DocumentLatency
35-
description: Your first network request is the most important. Reduce its latency by avoiding redirects, ensuring a fast server response, and enabling text compression.
35+
description: Your first network request is the most important. [Reduce its latency](https://developer.chrome.com/docs/performance/insights/document-latency) by avoiding redirects, ensuring a fast server response, and enabling text compression.
3636
relevant trace bounds: {min: 122410998910, max: 122411043781}
3737
estimated metric savings: FCP 0 ms, LCP 0 ms
3838
estimated wasted bytes: 77.1 kB
3939
example question: How do I decrease the initial loading time of my page?
4040
example question: Did anything slow down the request for this document?
4141
- insight name: ThirdParties
42-
description: 3rd party code can significantly impact load performance. [Reduce and defer loading of 3rd party code](https://web.dev/articles/optimizing-content-efficiency-loading-third-party-javascript/) to prioritize your page's content.
42+
description: 3rd party code can significantly impact load performance. [Reduce and defer loading of 3rd party code](https://developer.chrome.com/docs/performance/insights/third-parties) to prioritize your page's content.
4343
relevant trace bounds: {min: 122411037881, max: 122416229595}
4444
example question: Which third parties are having the largest impact on my page performance?
4545

0 commit comments

Comments
 (0)