Skip to content

fix: avoid reporting page close errors as errors #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OrKoN merged 1 commit into from
Sep 25, 2025
Merged

fix: avoid reporting page close errors as errors #127

OrKoN merged 1 commit into from
Sep 25, 2025

Conversation

@OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Sep 24, 2025

Closes #125

@OrKoN OrKoN requested a review from sebastianbenz September 24, 2025 19:06
@OrKoN OrKoN mentioned this pull request Sep 24, 2025
Closed
sebastianbenz
sebastianbenz reviewed Sep 24, 2025
View reviewed changes
@OrKoN
Copy link
Collaborator Author

OrKoN commented Sep 24, 2025

@sebastianbenz could you please try it with gemini-cli before we land it?

@sebastianbenz
Copy link
Collaborator

sebastianbenz commented Sep 24, 2025

I, of course, could not reproduce the exact situation. I tried explicilty triggering it by calling "close page" twice when only one page was open:


╭────────────────────╮
│  > Close the page  │
╰────────────────────╯

✦ Got it. Closing the page.
 ╭──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
 │ ✓  close_page (chrome-devtools MCP Server) {"pageIdx":1}                                                                             │
 │                                                                                                                                      │
 │    # close_page response                                                                                                             │
 │    ## Pages                                                                                                                          │
 │    0: about:blank [selected]                                                                                                         │
 ╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
✦ Page closed.

╭────────────────────╮
│  > Close the page  │
╰────────────────────╯

✦ I can't close the last page.

Using: 1 MCP server (ctrl+t to view)

After the first call to close the page, the tab was closed and the about:blank page appeard (which is as expected). For the second call I would've expected the message to be: "No active page", but that's more a minor nit.

@OrKoN OrKoN enabled auto-merge (squash) September 25, 2025 06:55
@OrKoN OrKoN requested a review from sebastianbenz September 25, 2025 08:06
sebastianbenz
sebastianbenz approved these changes Sep 25, 2025
View reviewed changes
Copy link
Collaborator

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@OrKoN OrKoN merged commit 44cfc8f into main Sep 25, 2025
27 of 29 checks passed
@OrKoN OrKoN deleted the orkon/close-pages branch September 25, 2025 10:40
@browser-automation-bot browser-automation-bot mentioned this pull request Sep 25, 2025
Merged
OzTamir pushed a commit to OzTamir/chrome-devtools-mcp that referenced this pull request Sep 25, 2025
@OrKoN @OzTamir
fix: avoid reporting page close errors as errors (ChromeDevTools#127)
ce6ea9c 
Closes ChromeDevTools#125
OrKoN pushed a commit that referenced this pull request Sep 25, 2025
@browser-automation-bot
chore(main): release chrome-devtools-mcp 0.3.0 (#138)
347768d 
🤖 I have created a release *beep* *boop*
---


##
[0.3.0](chrome-devtools-mcp-v0.2.7...chrome-devtools-mcp-v0.3.0)
(2025-09-25)


### Features

* Add pagination list_network_requests
([#145](#145))
([4c909bb](4c909bb))


### Bug Fixes

* avoid reporting page close errors as errors
([#127](#127))
([44cfc8f](44cfc8f))
* clarify the node version message
([#135](#135))
([0cc907a](0cc907a))
* do not set channel if executablePath is provided
([#150](#150))
([03b59f0](03b59f0))
* **performance:** ImageDelivery insight errors
([#144](#144))
([d64ba0d](d64ba0d))
* roll latest DevTools to handle Insight errors
([#149](#149))
([b2e1e39](b2e1e39))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastianbenz sebastianbenz sebastianbenz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Gemini shows error when trying to close the last page

2 participants

@OrKoN @sebastianbenz