fix(performance): ImageDelivery insight errors #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
approved these changes
Sep 25, 2025
This fixes the ImageDelivery insight which throws when we try to generate it because of its dependency on core/i18n. The long term fix here is to remove the reliance of models/trace on the core/i18n package, or at least dependency inject it, but this is a quick fix to at least make this insight available. The irony is that we don't even use the string in the AI output; but if we don't have the method available we cannot generate the insight. This fixes part of #124 by making this insight not error. The other required work for that bug is to deal with Insights that do error. That work is done in DevTools, but we need to ship & roll a new version into the MCP server.
OrKoN
force-pushed
the
jackfr/fixImageInsight
branch
from
15ad3c5 to
5c5452b
Compare
OzTamir
pushed a commit
to OzTamir/chrome-devtools-mcp
that referenced
this pull request
Sep 25, 2025
This fixes the ImageDelivery insight which throws when we try to generate it because of its dependency on core/i18n. The long term fix here is to remove the reliance of models/trace on the core/i18n package, or at least dependency inject it, but this is a quick fix to at least make this insight available. The irony is that we don't even use the string in the AI output; but if we don't have the method available we cannot generate the insight. This fixes part of ChromeDevTools#124 by making this insight not error. The other required work for that bug is to deal with Insights that do error. That work is done in DevTools, but we need to ship & roll a new version into the MCP server.
OrKoN
pushed a commit
that referenced
this pull request
Sep 25, 2025
🤖 I have created a release *beep* *boop* --- ## [0.3.0](chrome-devtools-mcp-v0.2.7...chrome-devtools-mcp-v0.3.0) (2025-09-25) ### Features * Add pagination list_network_requests ([#145](#145)) ([4c909bb](4c909bb)) ### Bug Fixes * avoid reporting page close errors as errors ([#127](#127)) ([44cfc8f](44cfc8f)) * clarify the node version message ([#135](#135)) ([0cc907a](0cc907a)) * do not set channel if executablePath is provided ([#150](#150)) ([03b59f0](03b59f0)) * **performance:** ImageDelivery insight errors ([#144](#144)) ([d64ba0d](d64ba0d)) * roll latest DevTools to handle Insight errors ([#149](#149)) ([b2e1e39](b2e1e39)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the ImageDelivery insight which throws when we try to generate it
because of its dependency on core/i18n. The long term fix here is to
remove the reliance of models/trace on the core/i18n package, or at
least dependency inject it, but this is a quick fix to at least make
this insight available.
The irony is that we don't even use the string in the AI output; but if
we don't have the method available we cannot generate the insight.
This fixes part of #124 by making this insight not error. The other
required work for that bug is to deal with Insights that do error. That
work is done in DevTools, but we need to ship & roll a new version into
the MCP server.