Skip to content

chore: Refactor adding extra nodes to snapshot #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wolfib merged 1 commit into from
Apr 24, 2026
+17 −8
Merged

chore: Refactor adding extra nodes to snapshot #1951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions src/TextSnapshot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,9 +231,12 @@ export class TextSnapshot {
};

const findDescendantNodes = async (
backendNodeId: number,
backendNodeId?: number,
): Promise<Set<number>> => {
const descendantIds = new Set<number>();
if (!backendNodeId) {
return descendantIds;
}
try {
// @ts-expect-error internal API
const client = page.pptrPage._client();
Expand Down Expand Up @@ -297,20 +300,26 @@ export class TextSnapshot {
if (extraHandles.length) {
page.extraHandles = extraHandles;
}
const reorgInfo: Array<{
extraNode: TextSnapshotNode;
attachTarget: TextSnapshotNode;
descendantIds: Set<number>;
}> = [];

for (const handle of page.extraHandles) {
const extraNode = await createExtraNode(handle);
if (!extraNode) {
continue;
}
idToNode.set(extraNode.id, extraNode);
const attachTarget = (await findAncestorNode(handle)) || rootNodeWithId;
if (extraNode.backendNodeId !== undefined) {
const descendantIds = await findDescendantNodes(
extraNode.backendNodeId,
);
const index = moveChildNodes(attachTarget, extraNode, descendantIds);
attachTarget.children.splice(index, 0, extraNode);
}
const descendantIds = await findDescendantNodes(extraNode.backendNodeId);
reorgInfo.push({extraNode, attachTarget, descendantIds});
}

for (const {extraNode, attachTarget, descendantIds} of reorgInfo) {
const index = moveChildNodes(attachTarget, extraNode, descendantIds);
attachTarget.children.splice(index, 0, extraNode);
}
}
}
Loading