refactor: remove onRelease functionality from Mutex #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@natorion Requested to review this pr |
Lightning00Blade
requested review from
Lightning00Blade
and removed request for
OrKoN
Lightning00Blade
changed the title
Collaborator
|
@mithun50 Please fix the code issue by running the formatters and I will review afterwards |
Contributor
Author
|
@Lightning00Blade formated successfully |
Lightning00Blade
approved these changes
Oct 2, 2025
Collaborator
Lightning00Blade
left a comment
Lightning00Blade
left a comment
There was a problem hiding this comment.
Looks good to me,
Thanks for the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Fixes #249
The
onReleasefunctionality in theMutexclass was unused.This change removes the
onReleasecallback from theacquiremethod and the
Guardclass, simplifying the implementation.