fix: guard performance_stop_trace when tracing inactive #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
leslieo2
changed the title
jackfranklin
approved these changes
Oct 7, 2025
Contributor
jackfranklin
left a comment
jackfranklin
left a comment
There was a problem hiding this comment.
Great catch, thank you for your fix!
Contributor
Author
|
Blocked by “workflows awaiting approval”, needs maintainer approval to run CI. |
OrKoN
pushed a commit
that referenced
this pull request
Oct 8, 2025
🤖 I have created a release *beep* *boop* --- ## [0.6.1](chrome-devtools-mcp-v0.6.0...chrome-devtools-mcp-v0.6.1) (2025-10-07) ### Bug Fixes * change default screen size in headless ([#299](#299)) ([357db65](357db65)) * **cli:** tolerate empty browser URLs ([#298](#298)) ([098a904](098a904)) * guard performance_stop_trace when tracing inactive ([#295](#295)) ([8200194](8200194)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
AlinaVarkki
pushed a commit
that referenced
this pull request
Oct 13, 2025
PR Description
- Fix the stop-trace guard to call context.isRunningPerformanceTrace()
so we skip page.tracing.stop() when nothing is recording, avoiding the
Puppeteer error that bubbled up
to users.
- Extend the “does nothing” test to stub tracing.stop() and assert it
stays untouched, guaranteeing the guard path is covered.
AlinaVarkki
pushed a commit
that referenced
this pull request
Oct 13, 2025
🤖 I have created a release *beep* *boop* --- ## [0.6.1](chrome-devtools-mcp-v0.6.0...chrome-devtools-mcp-v0.6.1) (2025-10-07) ### Bug Fixes * change default screen size in headless ([#299](#299)) ([357db65](357db65)) * **cli:** tolerate empty browser URLs ([#298](#298)) ([098a904](098a904)) * guard performance_stop_trace when tracing inactive ([#295](#295)) ([8200194](8200194)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
to users.
Testing